-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/loadbalancingexporter] amend README for data loss scenarios [chore] #31271
Merged
jpkrohling
merged 5 commits into
open-telemetry:main
from
alexchowle:loadbalancingexporter-data-loss-readme
Feb 19, 2024
Merged
[exporter/loadbalancingexporter] amend README for data loss scenarios [chore] #31271
jpkrohling
merged 5 commits into
open-telemetry:main
from
alexchowle:loadbalancingexporter-data-loss-readme
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o explain how topology changes can influence decisions around retry configuration, and how they can result in data loss.
jpkrohling
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing it so much better than I could ever do!
jpkrohling
approved these changes
Feb 19, 2024
jpkrohling
approved these changes
Feb 19, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
… [chore] (open-telemetry#31271) **Description:** amend the loadbalancingexporter README to explain how topology changes can influence decisions around retry configuration, and how they can result in data loss. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** 31209 **Testing:** N/A **Documentation:** README.ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: amend the loadbalancingexporter README to explain how topology changes can influence decisions around retry configuration, and how they can result in data loss.
Link to tracking Issue: 31209
Testing: N/A
Documentation: README.ms