Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/telemetrygen] Add Support for specifying Log Severity #30990
[cmd/telemetrygen] Add Support for specifying Log Severity #30990
Changes from 7 commits
7d01ff6
1ece692
b73eb53
6010732
9fbb318
1a2c543
0d62afb
daeb857
80e193f
e2b6adb
04c295b
1bd77f8
182586a
2d20159
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using the default when invalid data is present, we should return an error.
For example, if
severityNumber
is outside of the valid range, we should return an error that says that the valid range is [1,24].We may need to take care of the default case separately, but otherwise we shouldn't ignore what the user set, we should instead tell them that it is invalid.