Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/datadog] fix lifecycle #30472

Closed
wants to merge 3 commits into from
Closed

[connector/datadog] fix lifecycle #30472

wants to merge 3 commits into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 12, 2024 •
edited
Loading

Description:
fix start logic to start if tracesConsumer is present; make shutdown work even if start was not called

Related issue
Fixes #30487

@atoulme atoulme requested a review from mx-psi as a code owner January 12, 2024 07:17
@atoulme atoulme requested a review from a team January 12, 2024 07:17
@atoulme atoulme force-pushed the fix_datadogconnector_start branch from 50c4a19 to 956ca0d Compare January 12, 2024 07:17
@atoulme
Copy link
Contributor Author

atoulme commented Jan 12, 2024

Depends on #30471 to be merged first.

songy23
songy23 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dineshg13

songy23
songy23 requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry pressed the approve button by mistake

connector/datadogconnector/connector.go Outdated Show resolved Hide resolved
connector/datadogconnector/connector.go Outdated Show resolved Hide resolved
@atoulme atoulme force-pushed the fix_datadogconnector_start branch 3 times, most recently from 52f7d4f to 6116ed0 Compare January 12, 2024 21:45
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 27, 2024
songy23
songy23 reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31026 should unblock this.

@songy23 songy23 removed the Stale label Feb 5, 2024
@songy23
Copy link
Member

songy23 commented Feb 5, 2024

Please rebase

@atoulme atoulme force-pushed the fix_datadogconnector_start branch from 6116ed0 to 5d50391 Compare February 7, 2024 03:15
@github-actions github-actions bot requested a review from dineshg13 February 7, 2024 03:15
@atoulme atoulme force-pushed the fix_datadogconnector_start branch 2 times, most recently from ee33b99 to 33e5cde Compare February 7, 2024 03:16
@atoulme
Copy link
Contributor Author

atoulme commented Feb 7, 2024

@songy23 rebased

songy23
songy23 reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code is out of date, please run "make generate" and commit the changes in this PR.

Needs another rebase too

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 22, 2024
@dmitryax dmitryax added chore Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Stale labels Feb 28, 2024
@dmitryax
Copy link
Member

@atoulme can you please rebase?

@atoulme atoulme force-pushed the fix_datadogconnector_start branch from 3b655ee to e577758 Compare February 28, 2024 01:09
@atoulme
Copy link
Contributor Author

atoulme commented Feb 28, 2024

Done, will ping once tests complete if they pass.

@atoulme
Copy link
Contributor Author

atoulme commented Feb 28, 2024

Tests didn't pass. It looks like the "trace to metrics" path still fails. @songy23 what do you think?

songy23
songy23 reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I was under the impression that the recent changes should have fixed the shutdown, but it seems a different issue.

We will take a closer look and fix it to unblock this PR. cc @mackjmr

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 14, 2024
@mx-psi mx-psi removed the Stale label Mar 14, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 14, 2024

@mackjmr can you take a look?

@mackjmr mackjmr mentioned this pull request Mar 18, 2024
Merged
@mackjmr
Copy link
Member

mackjmr commented Mar 18, 2024

@atoulme put up #31811 to fix this, I think we can close this PR in favor of new one.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 18, 2024

Closing in favor of #31811

@atoulme atoulme closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 requested changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@dineshg13 dineshg13 Awaiting requested review from dineshg13

Assignees

@mx-psi mx-psi

Labels
chore connector/datadog Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[connector/datadog] Shutdown hangs
5 participants
@atoulme @songy23 @dmitryax @mx-psi @mackjmr