[exporter/logicmonitor] Update the lm-data-sdk-go version to v1.2.0 and fix error handling issue #30431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
I don't think so. |
|
cc: @khyatigandhi6 |
|
Changes looks good to me. No change log required as error handling is done as internal implementation. |
mx-psi
reviewed
Jan 11, 2024
Comment on lines
-51
to
-53
| if ingestResponse.Success { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I don't understand why this has been removed
There was a problem hiding this comment.
Because, with the updated SDK implementation if there is non empty error, then this success flag in the response is always false, so no need to check that explicitly and if error is nil then it is always true.
There was a problem hiding this comment.
Thanks for the explanation :) LGTM!
…ctor-contrib into fix-error-handling
mx-psi
approved these changes
Jan 12, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…nd fix error handling issue (open-telemetry#30431) **Description:** <Describe what has changed.> Fixing a bug - Using the updated version (v1.2.0) of `lm-data-sdk-go` causes each error to be considered as a permanent. This PR updates the version as well as changes the error handling to fix this issue. **Link to tracking Issue:** NA **Testing:** Unit and functional testing. **Documentation:** NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - Using the updated version (v1.2.0) of
lm-data-sdk-gocauses each error to be considered as a permanent. This PR updates the version as well as changes the error handling to fix this issue.Link to tracking Issue: NA
Testing: Unit and functional testing.
Documentation: NA