[chore] move loki receiver to generated lifecycle tests #30416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
loki_lifecycle
branch
from
037c248 to
0b2ee22
Compare
dmitryax
approved these changes
Jan 12, 2024
| @@ -9,3 +9,6 @@ status: | |||
| - sumo | |||
| codeowners: | |||
| active: [mar4uk, jpkrohling] | |||
|
|
|||
| tests: | |||
| config: | |||
There was a problem hiding this comment.
Unrelated to this PR. Once we apply this all components, we will enable the test generation by default, and these lines won't be needed anymore right?
There was a problem hiding this comment.
That sounds like a good next step to me.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #27849