Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move solace receiver to generated lifecycle tests #30413

Merged
merged 3 commits into from
Jan 22, 2024
Merged

[chore] move solace receiver to generated lifecycle tests #30413

merged 3 commits into from
Jan 22, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 11, 2024

Relates to #27849

@atoulme atoulme requested a review from djaglowski as a code owner January 11, 2024 02:09
@atoulme atoulme requested a review from a team January 11, 2024 02:09
@fatsheep9146
Copy link
Contributor

I think failed checks are related to this change.

--- FAIL: Test_ComponentLifecycle (0.00s)
    --- FAIL: Test_ComponentLifecycle/traces-shutdown (0.00s)
        generated_component_test.go:67: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/solacereceiver/generated_component_test.go:67
            	Error:      	Received unexpected error:
            	            	receiver/solace/solacereceiver/receiver_status: cannot register view "receiver/solace/solacereceiver/receiver_status"; a different view with the same name is already registered
            	            	receiver/solace/solacereceiver/need_upgrade: cannot register view "receiver/solace/solacereceiver/need_upgrade"; a different view with the same name is already registered
            	            	receiver/solace/solacereceiver/receiver_flow_control_status: cannot register view "receiver/solace/solacereceiver/receiver_flow_control_status"; a different view with the same name is already registered
            	            	receiver/solace/solacereceiver/receiver_flow_control_recent_retries: cannot register view "receiver/solace/solacereceiver/receiver_flow_control_recent_retries"; a different view with the same name is already registered
            	Test:       	Test_ComponentLifecycle/traces-shutdown

@atoulme
Copy link
Contributor Author

atoulme commented Jan 11, 2024

Seems like it registers more than once the opencensus view. Probably runs it several times between tests and I didn't notice because I just ran the new test. I'll look.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 22, 2024

I have resolved all comments, anything else pending to merge?

@djaglowski djaglowski merged commit 82484a2 into open-telemetry:main Jan 22, 2024
@github-actions github-actions bot added this to the next release milestone Jan 22, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@atoulme @cparkins
[chore] move solace receiver to generated lifecycle tests (open-telem…
6c714f8 
…etry#30413)

Relates to open-telemetry#27849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax left review comments

@djaglowski djaglowski djaglowski approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

Assignees

@fatsheep9146 fatsheep9146

Labels
receiver/solace
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @fatsheep9146 @djaglowski @dmitryax