[receiver/k8scluster] Add Node resource attributes #30343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
k8scluster/add-resource-attributes
branch
2 times, most recently
from
d10af64 to
523ab3c
Compare
TylerHelmuth
reviewed
Jan 9, 2024
| @@ -162,6 +162,21 @@ resource_attributes: | |||
| type: string | |||
| enabled: false | |||
|
|
|||
| k8s.container_runtime.version: | |||
There was a problem hiding this comment.
To be a little closer to the existing container semconv I think this should be k8s.container.runtime.version.
There was a problem hiding this comment.
Hmm given we have prefix containerd:// maybe we can actually do:
container.runtime = containerd
container.runtime.version = 1.2.23
This would be more aligned to the doc you linked.
Thoughts?
There was a problem hiding this comment.
Prefix is added in Kubelet here https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/nodestatus/setters.go#L412
There was a problem hiding this comment.
Updated, this is how it looks when using kind:
k8s_node_allocatable_cpu_{container_runtime="containerd", container_runtime_version="1.6.9", k8s_kubelet_version="v1.25.3", k8s_node_name="kind-control-plane", k8s_node_uid="29b8a758-ac58-45e7-9091-b9ed2e285be9", os_description="Ubuntu 22.04.1 LTS", os_version="6.6.10-arch1-1"}
4960f74 to
a5e2694
Compare
povilasv
force-pushed
the
k8scluster/add-resource-attributes
branch
from
a5e2694 to
9968a41
Compare
TylerHelmuth
approved these changes
Jan 12, 2024
dmitryax
approved these changes
Jan 12, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
) **Description:** I would like to use k8s cluster receiver to get more information about Node, such as Container Runtime Version, OS version and OS description. This is how it looks when using kind: ``` k8s_node_allocatable_cpu_{container_runtime="containerd", container_runtime_version="1.6.9", k8s_kubelet_version="v1.25.3", k8s_node_name="kind-control-plane", k8s_node_uid="29b8a758-ac58-45e7-9091-b9ed2e285be9", os_description="Ubuntu 22.04.1 LTS", os_version="6.6.10-arch1-1"} ``` **Link to tracking Issue:** open-telemetry#30342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I would like to use k8s cluster receiver to get more information about Node, such as Container Runtime Version, OS version and OS description.
This is how it looks when using kind:
Link to tracking Issue:
#30342
Testing:
Documentation: