-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[awsproxy] Expose service name as config option #29550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@atoulme Can you approve the pipeline? |
@atoulme Can you approve the pipeline once again? some test were failing. I have fixed them. |
@atoulme All test passed. Can we merge it? |
We need a review from codeowners. @dmitryax @Aneurysm9 please review |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This comment was marked as outdated.
This comment was marked as outdated.
@Aneurysm9 Gentle reminder |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This comment was marked as outdated.
This comment was marked as outdated.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This comment was marked as outdated.
This comment was marked as outdated.
Hello team, It has been 3 months since this PR is open. Seems like @Aneurysm9 is not active on this community anymore. how do you plan to continue the development of this plugin moving forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hello @bryan-aguilar , I have rebased my branch just now with latest main. Can you run the pipeline again? |
Seems like issues with podman permission, not related to my changes
|
awsproxy extension can be used as proxy to any service not just xray Signed-off-by: Arpit Agarwal <[email protected]>
@bryan-aguilar I have rebased my branch again. Can you please run the CI again. For some reason Github is showing 2 commits, but you can checkout locally it's just 1 commit. |
@arpitjindal97 noted, I think force pushing every commit may be causing some issues. Maybe try merging and pushing without a force instead? Force pushing also overwrites commit history on the branch/PR which makes it harder for reviewers to see what changes have been made. |
@bryan-aguilar nevermind, github is showing correct commit now. It’s ready to merge ✌️ |
awsproxy extension can be used as proxy to any service not just xray
Description:
The service name variable was hardcoded to "xray". This PR exposes it to be configurable in the config.yaml
Link to tracking Issue:
Testing:
Documentation:
Appropriate README of the extension has been updated to reflect the addition of new option