Promote 'log' to top of record in k8s examples #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2873 +/- ##
=======================================
Coverage 91.44% 91.45%
=======================================
Files 453 453
Lines 22302 22302
=======================================
+ Hits 20394 20396 +2
+ Misses 1431 1430 -1
+ Partials 477 476 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@djaglowski, Yes, I tested it and it looks perfect. Thanks! |
sumo-drosiek
approved these changes
Mar 29, 2021
|
We should update testbed configs as well |
tigrannajaryan
approved these changes
Apr 7, 2021
|
@djaglowski can you please also make the corresponding change on https://github.com/open-telemetry/opentelemetry-helm-charts ? |
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-helm-charts
that referenced
this pull request
Apr 7, 2021
This PR follows [#2873 (collector-contrib)](open-telemetry/opentelemetry-collector-contrib#2873)
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2851