[processor/resourcedetection] fix parsing error for windows #27678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
VihasMakwana
changed the title
ChrsMark
reviewed
Oct 16, 2023
VihasMakwana
force-pushed
the
fix-resource
branch
from
53e6859 to
9f461a3
Compare
mx-psi
approved these changes
Oct 16, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…emetry#27678) **Description:** The `system` detector extracts all the `cpu` info from the system even if you disable the configs and I believe this is where the bug kicks in. Disabling the settings will only stop it from setting the resource attributes. The [library](https://github.com/shirou/gopsutil/blob/v3.23.9/cpu/cpu_windows.go#L113) that we rely on doesn't extract some attributes for Windows OS (in this case, the field `cpu.Model`) and it leaves this field empty. This results in a bug when we try to parse an empty string. The long-term fix will be to extract `cpu.Model` in `gopsutil` upstream library. **Link to tracking Issue:** open-telemetry#27675
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…emetry#27678) **Description:** The `system` detector extracts all the `cpu` info from the system even if you disable the configs and I believe this is where the bug kicks in. Disabling the settings will only stop it from setting the resource attributes. The [library](https://github.com/shirou/gopsutil/blob/v3.23.9/cpu/cpu_windows.go#L113) that we rely on doesn't extract some attributes for Windows OS (in this case, the field `cpu.Model`) and it leaves this field empty. This results in a bug when we try to parse an empty string. The long-term fix will be to extract `cpu.Model` in `gopsutil` upstream library. **Link to tracking Issue:** open-telemetry#27675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
systemdetector extracts all thecpuinfo from the system even if you disable the configs and I believe this is where the bug kicks in. Disabling the settings will only stop it from setting the resource attributes.The library that we rely on doesn't extract some attributes for Windows OS (in this case, the field
cpu.Model) and it leaves this field empty. This results in a bug when we try to parse an empty string.The long-term fix will be to extract
cpu.Modelingopsutilupstream library.Link to tracking Issue: #27675