Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/signalfx] Remove redundant translation #27634

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[chore] [exporter/signalfx] Remove redundant translation #27634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions exporter/signalfxexporter/internal/translation/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,6 @@ package translation // import "github.com/open-telemetry/opentelemetry-collector
// Keep it in YAML format to be able to easily copy and paste it in config if modifications needed.
const DefaultTranslationRulesYaml = `
translation_rules:
# drops opencensus.resourcetype dimension from metrics generated by receivers written
# using OC data structures. This rule can be removed once the k8s_cluster and kubeletstats
# receivers have been refactored to use pmetric.Metrics. These dimensions are added as a
# result of the conversion here https://github.com/open-telemetry/opentelemetry-collector/blob/v0.22.0/translator/internaldata/oc_to_resource.go#L128.
# Dropping these dimensions will ensure MTSes aren't broken when the receivers are
# refactored and this resource type dimension will cease to exist.
- action: drop_dimensions
metric_name: /^(k8s\.|container\.).*/
dimension_pairs:
opencensus.resourcetype:
k8s: true
container: true

- action: copy_metrics
mapping:
# kubeletstats container cpu needed for calculation below
Expand Down