-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/signalfx] Attempt to resolve failing test #27608
Merged
dmitryax
merged 7 commits into
open-telemetry:main
from
crobert-1:fix_signalfx_correlate_fail
Oct 31, 2023
Merged
[chore][exporter/signalfx] Attempt to resolve failing test #27608
dmitryax
merged 7 commits into
open-telemetry:main
from
crobert-1:fix_signalfx_correlate_fail
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Oct 11, 2023
crobert-1
force-pushed
the
fix_signalfx_correlate_fail
branch
from
October 19, 2023 20:10
b7d54b0
to
57f47d4
Compare
The APM correlation test is failing with too many retry updates. This is an attempt to start determining the cause of the failure.
crobert-1
force-pushed
the
fix_signalfx_correlate_fail
branch
from
October 19, 2023 20:12
57f47d4
to
f443e2e
Compare
dmitryax
approved these changes
Oct 31, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…metry#27608) **Description:** The APM correlation test is failing with too many retry updates. The solution is to increase the `CleanupInterval` to allow the test time to make multiple correlation calls within the same dedup cleanup interval. I posted the full description in [this issue comment.](open-telemetry#27059 (comment)) Before this fix this test would fail _almost_ every time since it was introduced into this repo, I haven't seen any failure since this update (9 successful runs). **Link to tracking Issue:** Resolves open-telemetry#27059
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…metry#27608) **Description:** The APM correlation test is failing with too many retry updates. The solution is to increase the `CleanupInterval` to allow the test time to make multiple correlation calls within the same dedup cleanup interval. I posted the full description in [this issue comment.](open-telemetry#27059 (comment)) Before this fix this test would fail _almost_ every time since it was introduced into this repo, I haven't seen any failure since this update (9 successful runs). **Link to tracking Issue:** Resolves open-telemetry#27059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The APM correlation test is failing with too many retry updates. The solution is to increase the
CleanupInterval
to allow the test time to make multiple correlation calls within the same dedup cleanup interval. I posted the full description in this issue comment.Before this fix this test would fail almost every time since it was introduced into this repo, I haven't seen any failure since this update (9 successful runs).
Link to tracking Issue:
Resolves #27059
Testing:
Documentation: