Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/signalfx] Attempt to resolve failing test #27608

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Oct 10, 2023

Description:

The APM correlation test is failing with too many retry updates. The solution is to increase the CleanupInterval to allow the test time to make multiple correlation calls within the same dedup cleanup interval. I posted the full description in this issue comment.

Before this fix this test would fail almost every time since it was introduced into this repo, I haven't seen any failure since this update (9 successful runs).

Link to tracking Issue:
Resolves #27059

Testing:

Documentation:

crobert-1 and others added 4 commits October 19, 2023 13:10
The APM correlation test is failing with too many retry updates.
This is an attempt to start determining the cause of the failure.
@crobert-1 crobert-1 marked this pull request as ready for review October 20, 2023 14:01
@crobert-1 crobert-1 requested a review from a team October 20, 2023 14:01
@dmitryax dmitryax merged commit 66cc79c into open-telemetry:main Oct 31, 2023
83 checks passed
@crobert-1 crobert-1 deleted the fix_signalfx_correlate_fail branch October 31, 2023 16:45
@github-actions github-actions bot added this to the next release milestone Oct 31, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…metry#27608)

**Description:** 
The APM correlation test is failing with too many retry updates. The
solution is to increase the `CleanupInterval` to allow the test time to
make multiple correlation calls within the same dedup cleanup interval.
I posted the full description in [this issue
comment.](open-telemetry#27059 (comment))

Before this fix this test would fail _almost_ every time since it was
introduced into this repo, I haven't seen any failure since this update
(9 successful runs).

**Link to tracking Issue:** Resolves open-telemetry#27059
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…metry#27608)

**Description:** 
The APM correlation test is failing with too many retry updates. The
solution is to increase the `CleanupInterval` to allow the test time to
make multiple correlation calls within the same dedup cleanup interval.
I posted the full description in [this issue
comment.](open-telemetry#27059 (comment))

Before this fix this test would fail _almost_ every time since it was
introduced into this repo, I haven't seen any failure since this update
(9 successful runs).

**Link to tracking Issue:** Resolves open-telemetry#27059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/signalfx] TestCorrelationClient unit test failure
4 participants