-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/hostmetrics/memory] Add system.memory.usage{state=total} #27096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -8,7 +8,7 @@ attributes: | |||
state: | |||
description: Breakdown of memory usage by type. | |||
type: string | |||
enum: [buffered, cached, inactive, free, slab_reclaimable, slab_unreclaimable, used] | |||
enum: [total, buffered, cached, inactive, free, slab_reclaimable, slab_unreclaimable, used] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum: [total, buffered, cached, inactive, free, slab_reclaimable, slab_unreclaimable, used] | |
enum: [buffered, cached, free, inactive, slab_reclaimable, slab_unreclaimable, used, total] |
This was almost in alphabetical order, we may as well sort all of it.
Looks like the tests are relying on the index of datapoints within the gauge, and those are now off because of the new state. |
After discussion with the semantic conventions WG we are going to change the spec for this first to
|
Description:
Add
system.memory.usage
withstate=total
metric to report the total RAM memory available on the system.After open-telemetry/semantic-conventions/pull/89 this is a valid value for
system.memory.usage
.