[receiver/redis] include server.address and server.port resource attributes #26707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigilioso
force-pushed
the
redis-receiver-server-address-and-port
branch
from
49cf5db
to
234e0f2
Compare
songy23
approved these changes
Sep 15, 2023
|
Hey guys, I am facing a similar issue while collecting metrics from five different Redis instances. My question is, when is this PR going to get merged, and when is it expected to be released ? Big thanks for all the hard-work <3. |
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
| server.port: | ||
| description: Redis server's port | ||
| enabled: true | ||
| type: string |
There was a problem hiding this comment.
We could parse it to get the corresponding number, but it is a string when it is taken from the address
There was a problem hiding this comment.
it's fine, let's leave it as is
atoulme
approved these changes
Oct 25, 2023
atoulme
added
the
ready to merge
mx-psi
approved these changes
Nov 14, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…ibutes (open-telemetry#26707) **Description:** <Describe what has changed.> Two new resource attributes have been added: `server.address` and `server.port`. This is change aligned with [semantic conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.25.0/specification/semantic-conventions.md?plain=1#L30) and allows users identifying a particular redis server. **Link to tracking Issue:** open-telemetry#22044 **Testing:** <Describe what testing was performed and which tests were added.> ``` ❯ go test -race -timeout 300s -parallel 4 --tags="",integration --count 1 ./... ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver 6.179s ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/redisreceiver/internal/metadata 1.464s ``` * Added: new test to check error when the configuration endpoint is missing or invalid * Updated: integration test to check new resource attributes **Documentation:** <Describe the documentation added.> New attribute documentation was generated using `mdatagen` --------- Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Two new resource attributes have been added:
server.addressandserver.port. This is change aligned with semantic conventions and allows users identifying a particular redis server.Link to tracking Issue: #22044
Testing:
Documentation:
New attribute documentation was generated using
mdatagen