-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kubeletstats] Add resource getters #26690
Merged
TylerHelmuth
merged 4 commits into
open-telemetry:main
from
TylerHelmuth:kubeletstats-resource-maps
Sep 26, 2023
Merged
[receiver/kubeletstats] Add resource getters #26690
TylerHelmuth
merged 4 commits into
open-telemetry:main
from
TylerHelmuth:kubeletstats-resource-maps
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
kubeletstats-resource-maps
branch
from
September 14, 2023 17:00
c2d8114
to
0cb858a
Compare
TylerHelmuth
added
the
Skip Changelog
PRs that do not require a CHANGELOG.md entry
label
Sep 14, 2023
TylerHelmuth
force-pushed
the
kubeletstats-resource-maps
branch
from
September 14, 2023 17:04
0cb858a
to
477b974
Compare
TylerHelmuth
force-pushed
the
kubeletstats-resource-maps
branch
from
September 14, 2023 17:44
477b974
to
4e3c4c7
Compare
dmitryax
reviewed
Sep 19, 2023
@dmitryax ready for another review |
@dmitryax ready for another review |
dmitryax
approved these changes
Sep 26, 2023
Just a nit, don't want to block this anymore |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Add metadata map for pod and container requests and limits. Will be used to calculate new metrics in a future PR. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#24905 **Testing:** <Describe what testing was performed and which tests were added.> added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add metadata map for pod and container requests and limits. Will be used to calculate new metrics in a future PR.
Link to tracking Issue:
#24905
Testing:
added unit tests