Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix GitHub add-label workflow to ping codeowners #26362

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Aug 31, 2023

Description:

The add-label workflow is used by GitHub when manually adding labels to issues. When adding a new component to an issue, the workflow attempts to ping codeowners of the given component. However, the link to the ping codeowners script was outdated, and was failing. This change references the moved script.

Link to tracking Issue:
Resolves #26361

Testing:

Documentation:

The add-label workflow is used by GitHub when manually adding
labels to issues. When adding a new component to an issue,
the workflow attempts to ping codeowners of the given component.
However, the link to the ping codeowners script was outdated,
and was failing. This change references the moved script.
@crobert-1
Copy link
Member Author

Pinging @evan-bradley and @TylerHelmuth as I believe you both have the most context here.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! Keeping track of everything in these scripts can be difficult.

@evan-bradley evan-bradley merged commit 4fabc48 into open-telemetry:main Aug 31, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github add-labels script references non-existent ping-codeowners.sh script
3 participants