[receiver/kubeletstats] fix client to refresh service account tokens #26316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2
commented
Aug 30, 2023
| @@ -165,9 +166,27 @@ func (p *saClientProvider) BuildClient() (Client, error) { | |||
| } | |||
| tr := defaultTransport() | |||
| tr.TLSClientConfig = &tls.Config{ | |||
| RootCAs: rootCAs, | |||
| RootCAs: rootCAs, | |||
| InsecureSkipVerify: true, | |||
There was a problem hiding this comment.
We have not been passing the user provided InsecureSkipVerify config when authType is service account. I am keeping the same behavior here and will create a different issue to address this.
There was a problem hiding this comment.
#26319 Any ideas/context if this was done intentionally?
jinja2
commented
Aug 30, 2023
| require.NoError(t, err) | ||
| require.Equal(t, "s3cr3t", string(cl.(*clientImpl).tok)) |
There was a problem hiding this comment.
NewBearerAuthWithRefreshRoundTripper handles the authorization header for us, so removing this test case and replacing with the server validation check
jinja2
commented
Aug 30, 2023
| OSjOBwyTvlCIOF5AnafFuCk81EnbMLQeIvsfudXTAi0aw6HMmS2UgmGUcwGsFDRt | ||
| Xx1n1nLclK73f2a9mrzrh1s3lMom1FLaZ8fRecB9cVZJAHdw7RDtkG0qFf+v9Hk0 | ||
| y8JKVfSmRIveHz62a/61T36VSKIO0qksdR4wEPCjADsdpagVMrwjyu8qShLFXRkn | ||
| MIIFuDCCA6CgAwIBAgIUX6gHrM+cXSsdSQTFUTl7ISB8xoYwDQYJKoZIhvcNAQEL |
There was a problem hiding this comment.
updated cert since the ones checked in have expired
jinja2
force-pushed
the
fix-kubelet-client
branch
from
e404683 to
35679c6
Compare
dmitryax
reviewed
Aug 31, 2023
jinja2
force-pushed
the
fix-kubelet-client
branch
from
1b4fb5d to
c72e3b3
Compare
dmitryax
approved these changes
Sep 5, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supports refreshing service account tokens in the client used to communicate with kubelet
Link to tracking Issue:
Issue: 26120
Testing:
Updated unit tests
Local e2e testing in k8s cluster
Screenshot of local testing with 2 collector pods started at same time running the kubeletstats receiver and service account token expiration set to 10mins. The one of left is running old build and the one on right is the new build.