Add an interface in fileconsumer instead #25166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Create a Manager Interface for
fileconsumer
.This would result in a cleaner and more readable code for threadpool PR.
Going with the interface is much better and it will keep the threadpool wholly isolated.
@djaglowski, I have the threadpool changes ready to be pushed. I need to know your POV for my approach to moving towards interfaces.