Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/tailsampling] fix tailsampling lost instrumentation scope info #25117

Merged
merged 3 commits into from
Aug 31, 2023
Merged

[processor/tailsampling] fix tailsampling lost instrumentation scope info #25117

merged 3 commits into from
Aug 31, 2023

Conversation

siriusfreak
Copy link
Contributor

Description: Added saving instrumentation library information.
Fix issue: #13642

How solved:

  1. Add saving information about instrumentation scope for traces: processor/tailsamplingprocessor/processor.go:307
  2. Sampled spans will now be put into the previous version of the instrumentation scope: processor/tailsamplingprocessor/processor.go:435

Testing: on production with high load. Unit tests in progress

Documentation: no documentation changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@siriusfreak siriusfreak changed the title [processor/tailsampling] fix AND policy [processor/tailsampling] fix tailsampling lost instrumentation scope info Aug 9, 2023
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Aug 9, 2023
@github-actions github-actions bot requested a review from jpkrohling August 9, 2023 12:46
@siriusfreak siriusfreak force-pushed the fix-tailsampling-lost-instrumentation branch from 310e284 to 213a300 Compare August 11, 2023 07:32
@siriusfreak siriusfreak marked this pull request as ready for review August 11, 2023 07:32
@siriusfreak siriusfreak requested a review from a team August 11, 2023 07:32
@siriusfreak siriusfreak mentioned this pull request Aug 11, 2023
Closed
songy23
songy23 reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md#sign-the-cla

@siriusfreak
Copy link
Contributor Author

@songy23 signed

songy23
songy23 reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, please add a changelog

@TylerHelmuth TylerHelmuth merged commit 3e6c2a6 into open-telemetry:main Aug 31, 2023
@github-actions github-actions bot added this to the next release milestone Aug 31, 2023
@jpkrohling jpkrohling mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@songy23 songy23 songy23 approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees

@atoulme atoulme

Labels
processor/tailsampling Tail sampling processor
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@siriusfreak @jpkrohling @songy23 @TylerHelmuth @atoulme