Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/dataset] preallocate slice #24935

Merged
merged 2 commits into from
Aug 7, 2023
Merged

[chore] [exporter/dataset] preallocate slice #24935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b199c79
[chore]preallocate slice
atoulme Aug 5, 2023
6ab1ec3
Merge branch 'main' into datsetexporter_prealloc
atoulme Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exporter/datasetexporter/traces_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ type spanBundle struct {
}

func buildEventsFromTraces(ld ptrace.Traces, serverHost string) []*add_events.EventBundle {
var events []*add_events.EventBundle
var spans = make([]spanBundle, 0)

// convert spans into events
Expand All @@ -152,8 +151,9 @@ func buildEventsFromTraces(ld ptrace.Traces, serverHost string) []*add_events.Ev
}
}

for _, span := range spans {
events = append(events, buildEventFromSpan(span, serverHost))
events := make([]*add_events.EventBundle, len(spans))
for i, span := range spans {
events[i] = buildEventFromSpan(span, serverHost)
}

return events
Expand Down