Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add test to ensure metadata.yaml is present for all components #24643

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jul 27, 2023

Description:
This PR uses the checkfile tool introduced in open-telemetry/opentelemetry-go-build-tools#348 in order to validate the presence of the metadata.yaml file in all components. It also removes the checkdoc tool in favor of the checkfile tool, which is now also used to validate the presence of README.md.

Link to tracking Issue:
#23376

This PR uses the checkfile tool introduced in open-telemetry/opentelemetry-go-build-tools#348 in order to validate the presence of the metadata.yaml file in all components. It also removes the checkdoc tool in favor of the checkfile tool, which is now also used to validate the presence of README.md.
Issue: open-telemetry#23376
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 27, 2023
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitryax dmitryax merged commit bd5439c into open-telemetry:main Jul 27, 2023
@github-actions github-actions bot added this to the next release milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/tools ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants