Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] validate .chloggen entries in chores so no invalid changelog entries get committed #24273

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 14, 2023

See open-telemetry/opentelemetry-collector#8089 for origin.

When creating a chore PR, we don't check chloggen entries at all. If a chore introduces a changelog entry, we should validate it.

@atoulme atoulme requested review from a team and songy23 July 14, 2023 16:17
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 14, 2023
@codeboten codeboten merged commit 9a408c4 into open-telemetry:main Jul 14, 2023
@github-actions github-actions bot added this to the next release milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants