-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporter/datadogexporter: enhance example #24231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/docs-container-metrics
branch
from
July 12, 2023 11:05
2331dc8
to
024b6ca
Compare
mx-psi
previously approved these changes
Jul 12, 2023
you need to add the component factory |
songy23
approved these changes
Jul 12, 2023
Needs addressing checks CI:
|
gbbr
force-pushed
the
gbbr/docs-container-metrics
branch
from
July 13, 2023 12:41
bc2bf26
to
b81af5c
Compare
songy23
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a make gotidy
This change improves the collector.yaml example to contain information about container metrics.
gbbr
force-pushed
the
gbbr/docs-container-metrics
branch
from
July 14, 2023 08:37
b81af5c
to
e2dce6d
Compare
mx-psi
approved these changes
Jul 14, 2023
songy23
approved these changes
Jul 14, 2023
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/datadog
Datadog components
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the collector.yaml example to contain information about container tags and metrics.