Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/datadogexporter: enhance example #24231

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

gbbr
Copy link
Member

@gbbr gbbr commented Jul 12, 2023

This change improves the collector.yaml example to contain information about container tags and metrics.

@gbbr gbbr requested a review from a team July 12, 2023 10:48
@gbbr gbbr requested review from mx-psi and songy23 as code owners July 12, 2023 10:48
@gbbr gbbr added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 12, 2023
@github-actions github-actions bot added the exporter/datadog Datadog components label Jul 12, 2023
@github-actions github-actions bot requested review from dineshg13 and liustanley July 12, 2023 10:49
@gbbr gbbr force-pushed the gbbr/docs-container-metrics branch from 2331dc8 to 024b6ca Compare July 12, 2023 11:05
mx-psi
mx-psi previously approved these changes Jul 12, 2023
@mx-psi mx-psi dismissed their stale review July 12, 2023 12:24

needs changes on tests

@mx-psi
Copy link
Member

mx-psi commented Jul 12, 2023

-- FAIL: TestExamples (0.06s)
    --- FAIL: TestExamples/collector.yaml (0.03s)
        examples_test.go:48: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/datadogexporter/examples_test.go:48
            	Error:      	Received unexpected error:
            	            	cannot unmarshal the configuration: 1 error(s) decoding:
            	            	
            	            	* error decoding 'receivers': unknown type: "docker_stats" for id: "docker_stats" (valid values: [otlp hostmetrics filelog])
            	Test:       	TestExamples/collector.yaml
            	Messages:   	All yaml config must validate. Please ensure that all necessary component factories are added in newTestComponents()

you need to add the component factory

@mx-psi
Copy link
Member

mx-psi commented Jul 12, 2023

Needs addressing checks CI:

Replace statements are out of date, please run "make crosslink" and commit the changes in this PR.

@gbbr gbbr force-pushed the gbbr/docs-container-metrics branch from bc2bf26 to b81af5c Compare July 13, 2023 12:41
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a make gotidy

gbbr added 4 commits July 14, 2023 10:35
This change improves the collector.yaml example to contain information
about container metrics.
@gbbr gbbr force-pushed the gbbr/docs-container-metrics branch from b81af5c to e2dce6d Compare July 14, 2023 08:37
@gbbr gbbr requested a review from songy23 July 14, 2023 08:37
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 14, 2023
@mx-psi mx-psi merged commit e51f5c1 into open-telemetry:main Jul 14, 2023
@github-actions github-actions bot added this to the next release milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants