[cmd/mdatagen] Add unit test for metric collisions. #24229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Jul 12, 2023
songy23
added
ready to merge
crobert-1
approved these changes
Jul 12, 2023
|
CI action failure is frequency of #24223. |
atoulme
approved these changes
Jul 16, 2023
dmitryax
reviewed
Jul 18, 2023
This PR adds a unit test to check for metric collisions in receivers which have metrics defined. Issue: open-telemetry#23375
mackjmr
force-pushed
the
add-metric-collision-test
branch
from
6778d35 to
a7c0789
Compare
dmitryax
reviewed
Jul 20, 2023
Comment on lines
+125
to
+137
| seen := make(map[string]string) | ||
| for receiver, metrics := range allMetrics { | ||
| for _, metricName := range metrics { | ||
| // TODO: Remove one https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24009 and | ||
| // https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24008 have been addressed. | ||
| if metricName == "container.cpu.utilization" || metricName == "container.memory.rss" { | ||
| continue | ||
| } | ||
| val, exists := seen[metricName] | ||
| assert.False(t, exists, fmt.Sprintf("Collision for metric %v in receivers %v and %v \n", metricName, receiver, val)) | ||
| seen[metricName] = receiver | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think we ever decided that each receiver must emit unique metric names. I'd say we should remove this section until this decision is made.
dmitryax
requested changes
Jul 20, 2023
atoulme
removed
the
ready to merge
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Opened an issue: #26499. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a unit test to check for metric collisions in receivers which have metrics defined.
Link to tracking Issue:
#23375