[chore] make codecov upload retrying more resilient #23851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
previously approved these changes
Jun 30, 2023
|
I wonder if the specific failures you saw were a remnant of https://www.githubstatus.com/incidents/gqx5l06jjxhp. The timing doesn't quite match the status page timestamps, but it sounds reasonable to think that they could be related. |
|
We can wait a bit. If this happens again before this PR goes stale, we can merge it. |
|
Alright, let's do that :) |
mx-psi
dismissed
their stale review
Let's wait until we see this happening again
|
I saw this again on https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5462922968/jobs/9943452184?pr=23978, I think we can merge to see if it improves things |
mx-psi
approved these changes
Jul 5, 2023
mx-psi
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from retrying 5 times to retrying 10 times, and delays between retries from 10 to 15s.
This is based off the recent failures witnessed here:
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5416168149/jobs/9845939438?pr=23845