Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/httpcheck] fail fast on endpoint missing scheme #23808

Merged
merged 6 commits into from
Jul 11, 2023
Merged

[receiver/httpcheck] fail fast on endpoint missing scheme #23808

merged 6 commits into from
Jul 11, 2023

Conversation

andrzej-stencel
Copy link
Member

Fixes #23020

@andrzej-stencel andrzej-stencel requested a review from a team June 28, 2023 08:06
@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Jun 28, 2023
@andrzej-stencel
Copy link
Member Author

@codeboten I've marked this pull request as a bug_fix even though I had created the issue as an enhancement. Now I'm wondering if this shouldn't be marked as a breaking change? 🤔

codeboten
codeboten reviewed Jun 28, 2023
View reviewed changes
receiver/httpcheckreceiver/config_test.go Outdated Show resolved Hide resolved
.chloggen/httpcheck-parse-scheme.yaml Outdated Show resolved Hide resolved
codeboten
codeboten reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR may need a rebase depending on if it's merged before or after #23439

receiver/httpcheckreceiver/config_test.go Outdated Show resolved Hide resolved
@codeboten codeboten merged commit 676559a into open-telemetry:main Jul 11, 2023
@github-actions github-actions bot added this to the next release milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

Assignees

@kovrus kovrus

Labels
receiver/httpcheck HTTP Check receiver
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

[receiver/httpcheck] receiver should fail fast if endpoint with no scheme is provided
3 participants
@andrzej-stencel @codeboten @kovrus