Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testbed] Add zstd compression end-to-end tests for OTLP/HTTP #23456

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[testbed] Add zstd compression end-to-end tests for OTLP/HTTP #23456

merged 1 commit into from
Jul 21, 2023

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Jun 19, 2023 •
edited
Loading

No description provided.

@tigrannajaryan tigrannajaryan added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 19, 2023
@tigrannajaryan
Copy link
Member Author

Test failed as expected https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5315184475/jobs/9623279446?pr=23456

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 4, 2023
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlpzstd branch 3 times, most recently from 9985656 to 94a916b Compare July 4, 2023 16:10
@tigrannajaryan tigrannajaryan marked this pull request as ready for review July 4, 2023 16:32
@tigrannajaryan tigrannajaryan requested review from a team, MovieStoreGuy and dmitryax July 4, 2023 16:32
@tigrannajaryan
Copy link
Member Author

This is now ready for review.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlpzstd branch from 94a916b to c5bc997 Compare July 5, 2023 15:43
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 20, 2023
@tigrannajaryan
Copy link
Member Author

@open-telemetry/collector-contrib-approvers this is ready for review.

songy23
songy23 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit b6cff39 into open-telemetry:main Jul 21, 2023
@github-actions github-actions bot added this to the next release milestone Jul 21, 2023
@tigrannajaryan tigrannajaryan deleted the feature/tigran/otlpzstd branch July 21, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@songy23 songy23 songy23 approved these changes

@atoulme atoulme atoulme approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@Aneurysm9 Aneurysm9

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry testbed
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tigrannajaryan @jpkrohling @atoulme @songy23 @TylerHelmuth @Aneurysm9