[pkg/stanza] Move core time parsing capabilities to coreinternal #23232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
github-actions
bot
added
connector/count
exporter/signalfx
internal/core
internal/filter
pkg/ottl
pkg/stanza
processor/attributes
github-actions
bot
requested review from
bogdandrutu,
boostchicken,
crobert-1,
djaglowski,
dmitryax,
evan-bradley,
jpkrohling,
kentquirk,
kovrus and
pjanotti
TylerHelmuth
force-pushed
the
move-timeparser-to-internal
branch
2 times, most recently
from
f9a0196 to
83bbbe7
Compare
TylerHelmuth
removed
processor/attributes
djaglowski
approved these changes
Jun 8, 2023
crobert-1
reviewed
Jun 8, 2023
TylerHelmuth
force-pushed
the
move-timeparser-to-internal
branch
from
3a06d91 to
de266b6
Compare
crobert-1
approved these changes
Jun 8, 2023
evan-bradley
reviewed
Jun 9, 2023
evan-bradley
approved these changes
Jun 9, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…n-telemetry#23232) * Move core time parsing capabilities to coreinternal * Add clarifying comment * Apply suggestions from code review Co-authored-by: Curtis Robert <[email protected]> * Replace StrptimeToGo with ParseStrptime * remove changelog --------- Co-authored-by: Faith Chikwekwe <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moves strptime and native Go format parsing from stanza's
TimeParserstruct tocoreinternalso it can be used by OTTL.To keep the PR as small as possible and to reduce risk only the strptime and go parsing capabilities are shared. Maybe more can be moved in the future, but these are currently the only pieces OTTL needs. The implementation in
timeutilsalso tries to be as similar to the original implementation as possible.The
TimeParserAPI is unchanged so this should not be a breaking change.Issue
Unblocks #22811, which needs this functionality to parse time the same way as stanza.