Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Replace StandardTypeGetter with type-specific implementations #22763

Conversation

TylerHelmuth
Copy link
Member

Description:
Replaces StandardTypeGetter with type-specific implementations to facilitate converting from pcommon.Value types when able. This capability is an important abstraction for users who may not know when a field is a string or a pcommon.ValueTypeStr for example.

Link to tracking Issue:
Related to #22161

Testing:
Added new tests

pkg/ottl/expression.go Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 4014092 into open-telemetry:main May 30, 2023
@TylerHelmuth TylerHelmuth deleted the ottl-treat-primitive-and-pdata-the-same-2 branch May 30, 2023 15:14
@github-actions github-actions bot added this to the next release milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants