[receiver/dockerstats] Change cpu utilization metric #22159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossscastro
changed the title
…pen-telemetry#22141) * [chore]Migrate aerospike integration test to new framework
…pen-telemetry#22142) * [chore] Migrate sqlquery to scraper integration test framework
Signed-off-by: Bogdan Drutu <[email protected]>
|
@carlossscastro sorry I should have thought about this and mentioned this before: with a metric name change like this, we should be able to get away without a feature gate, instead using the regular metric enabling/disabling capabilities and a description of the deprecation in the README file. See similar issue and PRs in the Host Metrics receiver:
Do you think we can do it this way? Again, very sorry for bringing this up after you implemented the feature gate. 😟 |
(open-telemetry#17020) * [schema processor] Modifier A modifier allows mutating a signal from a previous version to the current one and vice versa. [schema processor] Adding revisions A revision handles applying the modifiers to incoming signals and converting a signal to the next version. * Adding changes * Adding migrate package. Following patterns similar to databases where you'd apply changes and rollback. the Migrate packages follows these designs to help make it clear what it is trying to do. * Removing modiferies to avoid confusion * Fixing up naming issues * Adding checks in for building a revision * Fixing up replaces * Removing transform files * Fixing naming * Fixing up conflict * Fixing typo * Updating naming * Fixing up ast usage * FIxing up generated mod files * Fixing up license headers
…etry#22700) * [exporter/datasetexporter]: Enable in internal components * Add changelog entry * Modify go.mod and go.sum files
…lemetry#22059) * Add IntLikeGetter * changelog * fix lint * Update pkg/ottl/expression_test.go Co-authored-by: Evan Bradley <[email protected]> * Update pkg/ottl/expression_test.go Co-authored-by: Evan Bradley <[email protected]> --------- Co-authored-by: Evan Bradley <[email protected]>
…etry#22707) Signed-off-by: Anthony J Mirabella <[email protected]>
Corrected some invalid docs in README: - This receiver does not use gRPC, replaced with HTTP config - This receiver does not use queuing, retry and timeout settings from exporterhelper
…g keys (open-telemetry#22708) Allow capture groups in replace_all_patterns when using the key mode Co-authored-by: Evan Bradley <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
No problem at all @astencel-sumo. I will work on this and resubmit the PR. Thanks again for the guidance. |
carlossscastro
requested review from
fatsheep9146,
jpkrohling,
kovrus,
mx-psi,
TylerHelmuth,
bogdandrutu,
evan-bradley,
jsuereth,
arminru and
songy23
as code owners
github-actions
bot
added
cmd/configschema
|
@carlossscastro please take a look at the PR, I think you have had a weird push. |
|
Resubmitting in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change starts the process for deprecating the metric
container.cpu.percentin favor ofcontainer.cpu.utilizationto adhere to semantic convention.New metric naming is under a feature-gate that can be enabled with:
Link to tracking Issue: #21807
Testing:
Documentation:
Metrics documentation was updated using
mdatagen