-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] add example k8s configs #2193
[exporter/datadog] add example k8s configs #2193
Conversation
would like to have this reviewed by colleagues at datadog before merging, thanks! cc @mx-psi |
Codecov Report
@@ Coverage Diff @@
## master #2193 +/- ##
==========================================
- Coverage 90.48% 90.46% -0.02%
==========================================
Files 397 397
Lines 19593 19593
==========================================
- Hits 17728 17725 -3
- Misses 1403 1406 +3
Partials 462 462
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -0,0 +1,257 @@ | |||
# This manifest file is meant as an example of how to deloy otel-agent's as daemonset and otel-collector as a standalone service | |||
# In a way the correctly identifies hostnames for individual k8s nodes. This is meant as an example only and may differ depending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is missing in this sentence, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yup, updated.
Do you mind if I ask why this component must have a Kubernetes example? We have Kubernetes examples in the main repository, and no individual component has one, to my knowledge. Nothing really against it, just trying to understand if there's something special about this component. |
@jpkrohling no worries at all, don't mind you asking. So, we've been working on onboarding documentation for datadog's docs (this is public, feel free to take a look: DataDog/documentation#9529) , and noticed that a lot of users of otel at datadog are new to both otel and datadog at the same time, and so documenting things in a way that is just an incremental "add these exporters or processors to an existing setup" is confusing because there is no existing setup. Additionally, the current k8s docs we've found to be not a wonderful fit for capturing metadata that is especially important for a vendor like ddog that is doing host count-based billing. Specifically there's no node or pod level information captured here via a So, all those things combined, it's just far easier and simpler to have a single doc that helps users onboard to datadog and OpenTelemetry simultaneously. And we'd prefer that doc not be Additionally, when we have our vendor specific docs in a good place and verified with users, we'd like to contribute back upstream to the main docs repo for otel. we've found that the docker examples and k8s examples there have room for improvement. Once those are in a better place we'll try to migrate to using those, but in the meantime we'd prefer to have strong examples within the For context, we've found there are a number of other vendors that are taking a similar approach to what we're doing, but choosing to keep their examples and docs proprietary or hosted largely within their own repos. We feel the approach we're taking is more community friendly. Let me know if that sounds reasonable or if there's anything we can provide here to improve the comfort level around this. |
Thanks for the explanation, sounds good to me.
+1, I have a blog post draft ready to be submitted on this topic, as I don't think the examples are satisfactory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should open the issues needed for these docs to be updated in the k8s_tagger and in the OpenTelemetry docs.
…om component (#2193) Signed-off-by: Bogdan Drutu <[email protected]>
* [exporter/datadog]: add example k8s manifest * [exporter/datadog]: update readme * [exporter/datadog]: fix examples for k8s * [exporter/datadog]: update docs
Description:
Adds an example k8s manifest for deploying the collector as agent and as collector in a k8s environment, with datadog specific processors and exporters enabled.
Link to tracking Issue:
Testing:
Documentation: