Make sure the k8scluster receiver is watching for hpa v2 #21497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I missed adding the hpa v2 to the watcher.
Link to tracking Issue: #20480
Testing:
Added more unit tests. Verified k8s.hpa.* metrics for v2 objects are exporting.
Tested manually with:
Note:
I haven't been able to stop/catch this warning in Kubernetes 1.25, I couldn't find what was throwing it in the receiver code. This isn't an issue in 1.26. If I can track it down, I'll add another commit.
1 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler