Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the k8scluster receiver is watching for hpa v2 #21497

Merged
merged 1 commit into from
May 5, 2023

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented May 5, 2023

Description:
I missed adding the hpa v2 to the watcher.

Link to tracking Issue: #20480

Testing:
Added more unit tests. Verified k8s.hpa.* metrics for v2 objects are exporting.
Tested manually with:

  • Kubernetes 1.25: Rosa 4.12, Kops on AWS, Minikube

Note:
I haven't been able to stop/catch this warning in Kubernetes 1.25, I couldn't find what was throwing it in the receiver code. This isn't an issue in 1.26. If I can track it down, I'll add another commit.
1 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

…HorizontalPodAutoscalers for Kubernetes 1.26
@jvoravong jvoravong requested a review from a team May 5, 2023 01:34
@jvoravong jvoravong requested a review from dmitryax as a code owner May 5, 2023 01:34
@dmitryax dmitryax merged commit 5bb35a4 into open-telemetry:main May 5, 2023
@github-actions github-actions bot added this to the next release milestone May 5, 2023
@dmitryax
Copy link
Member

dmitryax commented May 5, 2023

Thanks @jvoravong!

@salapatt
Copy link

salapatt commented May 22, 2023

The customer updated the Splunk OTC agent to version 0.77.0 and still gets the same error messages.

W0522 06:11:24.226426 1 reflector.go:533] k8s.io/[email protected]/tools/cache/reflector.go:231mailto:[k8s.io/[email protected]/tools/cache/reflector.go:231](https://k8s.io/[email protected]/tools/cache/reflector.go:231): failed to list *v2beta1.HorizontalPodAutoscaler: the server could not find the requested resource
129E0522 06:11:24.226454 1 reflector.go:148] k8s.io/[email protected]/tools/cache/reflector.go:231mailto:[k8s.io/[email protected]/tools/cache/reflector.go:231](https://k8s.io/[email protected]/tools/cache/reflector.go:231): Failed to watch *v2beta1.HorizontalPodAutoscaler: failed to list *v2beta1.HorizontalPodAutoscaler: the server could not find the requested resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants