-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/jaegerremotesampling]: Replace Thrift-gen with Proto-gen types for sampling strategies #18485
Merged
codeboten
merged 24 commits into
open-telemetry:main
from
frzifus:jaegerremotesampling_replace_thrift-gen_with_proto-gen
Sep 6, 2023
+6,374
−181
Merged
[extension/jaegerremotesampling]: Replace Thrift-gen with Proto-gen types for sampling strategies #18485
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e24018d
[extension/jaegerremotesampling] move current state into deprecated pkg
frzifus 9bd7d5c
[extension/jaegerremotesampling] remove mod files from deprecated pkg
frzifus 72d7113
[extension/jaegerremotesampling] bump jaeger version from 1.41 to 1.48
frzifus 0d315e7
[extension/jaegerremotesampling] register featuregate
frzifus 5297c36
[pkg/translator/zipkin] bump to jaeger 1.48
frzifus 4e94c5f
[receiver/jaegerreceiver] move current state into deprecated pkg
frzifus eaf7368
[receiver/jaegerreceiver] bump jaeger to 1.48
frzifus 855a8de
[receiver/jaegerreceiver] register featuregate
frzifus fb46ce5
*: add changelog entry
frzifus 07d1505
Update extension/jaegerremotesampling/factory.go
frzifus b990974
jaeger: add otel license header
frzifus c72a3e7
[extension/jaegerremotesampling] move old jaeger impl into internal
frzifus e8fe9c1
[receiver/jaegerreceiver] move old jaeger impl into internal
frzifus e660754
fix pkg paths
frzifus f80dfe5
*: make gotidy
frzifus 497f7e2
fix
frzifus 3982190
[extension/jaegerremotesampling] fix linting
frzifus b3045aa
[receiver/jaegerreceiver] fix linting
frzifus 6468cce
Merge branch 'main' into jaegerremotesampling_replace_thrift-gen_with…
frzifus 8e96c1c
Merge branch 'main' into jaegerremotesampling_replace_thrift-gen_with…
frzifus a4f2962
fix
frzifus f99ee72
Merge branch 'main' into jaegerremotesampling_replace_thrift-gen_with…
frzifus c542a2b
Merge branch 'main' into jaegerremotesampling_replace_thrift-gen_with…
frzifus 25bd3b9
Merge branch 'main' into jaegerremotesampling_replace_thrift-gen_with…
frzifus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
.chloggen/jaegerremotesampling_replace_thrift-gen_with_proto-gen.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
| component: jaegerreceiver,jaegerremotesamplingextension | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add featuregates to replace Thrift-gen with Proto-gen types for sampling strategies | ||
|
|
||
| # One or more tracking issues related to the change | ||
| issues: [18401] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| Available featuregates are: | ||
| - extension.jaegerremotesampling.replaceThriftWithProto | ||
| - receiver.jaegerreceiver.replaceThriftWithProto | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding a featuregate to the
jaegerremotesamplingextensionthe module worked fine, but it was not possible to compile the contrib client. Since otelcontribcol used 1.48.Log
Therefore, I have increased the version there the same way and provided another feature gate. They work independently of each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jpkrohling @zcross @MovieStoreGuy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a temporary solution, it's fine.