[pkg/pdatatest] add more test cases for trace #18031

fatsheep9146 · 2023-01-25T14:19:38Z

Signed-off-by: Ziqi Zhao [email protected]

Description:
fix #18030
partly of #17544

runforesight · 2023-01-25T14:20:52Z

Foresight Summary

Major Impacts

build-and-test-windows duration(4 seconds) has decreased 41 minutes 3 seconds compared to main branch avg(41 minutes 7 seconds).

View More Details

⭕ build-and-test-windows workflow has finished in 4 seconds (41 minutes 3 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

✅ check-links workflow has finished in 43 seconds (1 minute 7 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 48 seconds (1 minute 36 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
publish-latest	- 🔗	N/A	See Details
build-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 55 seconds (1 minute 30 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
publish-latest	- 🔗	N/A	See Details
build-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ changelog workflow has finished in 2 minutes and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (3 minutes 52 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ build-and-test workflow has finished in 35 minutes 43 seconds (16 minutes 22 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.19, internal)	- 🔗	✅ 561 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, internal)	- 🔗	✅ 561 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1471 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1471 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2567 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2567 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2413 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2413 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1944 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4655 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4655 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 55 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1944 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 8 minutes 59 seconds (5 minutes 16 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

bogdandrutu · 2023-01-26T00:08:47Z

/cc @dmitryax

dmitryax · 2023-01-26T00:17:23Z

@fatsheep9146 please rebase

Signed-off-by: Ziqi Zhao <[email protected]>

fatsheep9146 · 2023-01-26T05:20:50Z

@fatsheep9146 please rebase

Done @dmitryax

dmitryax

LGTM. Thanks @fatsheep9146

dmitryax · 2023-01-26T06:39:17Z

pkg/pdatatest/ptracetest/traces.go

@@ -287,8 +287,7 @@ func CompareSpan(expected, actual ptrace.Span) error {
 	}

 	if !reflect.DeepEqual(expected.Events(), actual.Events()) {
-		errs = multierr.Append(errs, fmt.Errorf("events doesn't match expected: %v, actual: %v",
-			expected.Events(), actual.Events()))
+		errs = multierr.Append(errs, fmt.Errorf("events doesn't match"))


We need to expand this comparison. I submitted another issue. Feel free to take it if you're interested #18049

ok, I take this @dmitryax

pkg/pdatatest/ptracetest/traces_test.go

dmitryax · 2023-01-26T07:26:36Z

.chloggen/add_test_for_traces.yaml

+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:


Forgot to mention that we shouldn't add changelog entries for test coverage since it's not a user-facing change. Please submit another PR to remove this entry

fatsheep9146 requested a review from a team January 25, 2023 14:19

fatsheep9146 requested a review from djaglowski as a code owner January 25, 2023 14:19

fatsheep9146 assigned dmitryax Jan 25, 2023

github-actions bot assigned jpkrohling Jan 25, 2023

fatsheep9146 added the pkg/pdatatest label Jan 25, 2023

bogdandrutu approved these changes Jan 26, 2023

View reviewed changes

[pkg/pdatatest] add more test cases for trace

d024895

Signed-off-by: Ziqi Zhao <[email protected]>

fatsheep9146 force-pushed the add-test-for-traces branch from f6c0dc6 to d024895 Compare January 26, 2023 05:03

dmitryax approved these changes Jan 26, 2023

View reviewed changes

dmitryax merged commit 34b31da into open-telemetry:main Jan 26, 2023

dmitryax reviewed Jan 26, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pkg/pdatatest] add more test cases for trace #18031

[pkg/pdatatest] add more test cases for trace #18031

fatsheep9146 commented Jan 25, 2023

runforesight bot commented Jan 25, 2023 •

edited

Loading

`build-and-test-windows` duration(4 seconds) has decreased 41 minutes 3 seconds compared to main branch avg(41 minutes 7 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (41 minutes 3 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ check-links workflow has finished in 43 seconds (1 minute 7 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ telemetrygen workflow has finished in 48 seconds (1 minute 36 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ tracegen workflow has finished in 55 seconds (1 minute 30 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ changelog workflow has finished in 2 minutes and finished at 26th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (3 minutes 52 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ build-and-test workflow has finished in 35 minutes 43 seconds (16 minutes 22 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ load-tests workflow has finished in 8 minutes 59 seconds (5 minutes 16 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

bogdandrutu commented Jan 26, 2023

dmitryax commented Jan 26, 2023

fatsheep9146 commented Jan 26, 2023 •

edited

Loading

dmitryax left a comment

dmitryax Jan 26, 2023

fatsheep9146 Jan 26, 2023

dmitryax Jan 26, 2023

[pkg/pdatatest] add more test cases for trace #18031

[pkg/pdatatest] add more test cases for trace #18031

Conversation

fatsheep9146 commented Jan 25, 2023

runforesight bot commented Jan 25, 2023 • edited Loading

Foresight Summary

build-and-test-windows duration(4 seconds) has decreased 41 minutes 3 seconds compared to main branch avg(41 minutes 7 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (41 minutes 3 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ check-links workflow has finished in 43 seconds (1 minute 7 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ telemetrygen workflow has finished in 48 seconds (1 minute 36 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ tracegen workflow has finished in 55 seconds (1 minute 30 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ changelog workflow has finished in 2 minutes and finished at 26th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (3 minutes 52 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ build-and-test workflow has finished in 35 minutes 43 seconds (16 minutes 22 seconds less than main branch avg.) and finished at 26th Jan, 2023.

✅ load-tests workflow has finished in 8 minutes 59 seconds (5 minutes 16 seconds less than main branch avg.) and finished at 26th Jan, 2023.

bogdandrutu commented Jan 26, 2023

dmitryax commented Jan 26, 2023

fatsheep9146 commented Jan 26, 2023 • edited Loading

dmitryax left a comment

Choose a reason for hiding this comment

dmitryax Jan 26, 2023

Choose a reason for hiding this comment

fatsheep9146 Jan 26, 2023

Choose a reason for hiding this comment

dmitryax Jan 26, 2023

Choose a reason for hiding this comment

runforesight bot commented Jan 25, 2023 •

edited

Loading

`build-and-test-windows` duration(4 seconds) has decreased 41 minutes 3 seconds compared to main branch avg(41 minutes 7 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (41 minutes 3 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ check-links workflow has finished in 43 seconds (1 minute 7 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ telemetrygen workflow has finished in 48 seconds (1 minute 36 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ tracegen workflow has finished in 55 seconds (1 minute 30 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (3 minutes 52 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ build-and-test workflow has finished in 35 minutes 43 seconds (16 minutes 22 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

✅ load-tests workflow has finished in 8 minutes 59 seconds (5 minutes 16 seconds less than `main` branch avg.) and finished at 26th Jan, 2023.

fatsheep9146 commented Jan 26, 2023 •

edited

Loading