Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] Expose resource_attributes option in user settings #17967

Merged

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Jan 23, 2023

Description:
Change constructor of MetricsBuilder from MetricsSettings to MetricsBuilderConfig, and wrap MetricsSettings and ResourceAttributesSettings with such.

This change exposes resource_attributes option in the user config which can be used to enable/disable particular resource_attributes.

Link to tracking Issue: #16373

Testing:
make mdatagen-test && make generate && make test

receiver/snmpreceiver/config.go Outdated Show resolved Hide resolved
.chloggen/metrics_builder_constructor_ms_to_mbc.yaml Outdated Show resolved Hide resolved
.chloggen/metrics_builder_constructor_ms_to_mbc.yaml Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member

Sounds good. thanks! Please submit a separate issue for snowflake receiver

@hughesjj
Copy link
Contributor Author

@dmitryax
Copy link
Member

@hughesjj please rebase and re-generate the code

@hughesjj hughesjj force-pushed the MetricsSettings_to_MetricsBuilderConfig branch from 21ff169 to 8f55615 Compare January 26, 2023 06:16
@runforesight
Copy link

runforesight bot commented Jan 26, 2023

Foresight Summary

    
Major Impacts

build-and-test duration(35 minutes 41 seconds) has decreased 33 minutes 8 seconds compared to main branch avg(1 hour 8 minutes 49 seconds).
View More Details

✅  tracegen workflow has finished in 1 minute 1 second (1 minute 24 seconds less than main branch avg.) and finished at 27th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 9 seconds (41 minutes 30 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 44 seconds (1 minute 41 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 55 seconds (2 minutes 6 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 54 seconds (52 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  build-and-test workflow has finished in 35 minutes 41 seconds (33 minutes 8 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1513  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, processor) -     🔗  ✅ 1513  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2577  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-0) -     🔗  ✅ 2577  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) -     🔗  ✅ 2457  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2457  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1932  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) -     🔗  ✅ 1932  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) -     🔗  ✅ 4776  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4776  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 7 minutes 11 seconds (10 minutes 4 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 4 minutes (5 minutes 9 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 11 minutes 21 seconds (4 minutes 26 seconds less than main branch avg.) and finished at 24th Feb, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@hughesjj hughesjj force-pushed the MetricsSettings_to_MetricsBuilderConfig branch from d061448 to b650009 Compare February 24, 2023 03:17
receiver/awscloudwatchreceiver/config.go Outdated Show resolved Hide resolved
receiver/dockerstatsreceiver/config.go Outdated Show resolved Hide resolved
cmd/mdatagen/templates/metrics_test.go.tmpl Outdated Show resolved Hide resolved
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe this can be merged now. Please move it from draft

@dmitryax dmitryax marked this pull request as ready for review February 27, 2023 23:57
@dmitryax dmitryax requested a review from a team February 27, 2023 23:57
@dmitryax
Copy link
Member

dmitryax commented Feb 27, 2023

Let's keep it open for a day in case other folks have comments

@dmitryax dmitryax changed the title Change MetricsSettings -> MetricsBuilderConfig in mdatagen [cmd/mdatagen] Expose resource_attributes option in user settings Feb 28, 2023
@dmitryax dmitryax merged commit b40e984 into open-telemetry:main Feb 28, 2023
@hughesjj
Copy link
Contributor Author

hughesjj commented Mar 1, 2023

here's hoping we squashed merged that one 😂🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants