Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/statsd] Fix statsd server start order #17403

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 6, 2023

Description:
Fix the statsdreceiver initialization to only create a server when Start is called.

Link to tracking Issue:
#17402

Testing:
Moved unit tests around.

@runforesight
Copy link

runforesight bot commented Jan 6, 2023

Foresight Summary

    
Major Impacts

TestStartAndShutdownRemote ❌ failed 1 times in 4 runs (25% fail rate).
build-and-test-windows duration(3 seconds) has decreased 46 minutes 11 seconds compared to main branch avg(46 minutes 14 seconds).
View More Details

✅  check-links workflow has finished in 47 seconds (2 minutes 18 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 4 seconds (2 minutes 21 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 11 seconds (6 minutes 6 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

 build-and-test workflow has finished in 15 minutes 18 seconds (33 minutes 9 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, internal) N/A  ✅ 595  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 595  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1469  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1469  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2563  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2563  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2462  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2462  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4399  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4399  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1887  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1887  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 8 minutes 32 seconds (8 minutes 11 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 3 seconds (46 minutes 11 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 49 seconds (6 minutes 49 seconds less than main branch avg.) and finished at 6th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see the same issue with the carbon receiver. Probably should be fixed as well

@atoulme
Copy link
Contributor Author

atoulme commented Jan 6, 2023

I'll take care of the carbon receiver right away.

@dmitryax
Copy link
Member

dmitryax commented Jan 6, 2023

Thanks!

@atoulme
Copy link
Contributor Author

atoulme commented Jan 6, 2023

Build fails with flaky test: #9113
Will rerun.

@dmitryax dmitryax changed the title Fix statsd server start order [receiver/statsd] Fix statsd server start order Jan 6, 2023
@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Jan 6, 2023
@dmitryax dmitryax merged commit 3ba142c into open-telemetry:main Jan 6, 2023
@atoulme atoulme deleted the fix_statsd_order branch January 6, 2023 02:32
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/statsd statsd related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants