Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/splunkhec] fix flaky test expecting all requests to be gzipped. #17178

Merged
merged 6 commits into from
Dec 21, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 20, 2022

Description:
Fix flaky test expecting all requests to be gzipped. The last request might not be zipped.

Link to tracking Issue:
#17177

Testing:
Ran the test locally and didn't see a flaky behavior anymore.

Documentation:
N/A

@runforesight
Copy link

runforesight bot commented Dec 20, 2022

Foresight Summary

    
Major Impacts

build-and-test duration(40 minutes 19 seconds) has decreased 19 minutes 38 seconds compared to main branch avg(59 minutes 57 seconds).
View More Details

✅  check-links workflow has finished in 41 seconds (2 minutes 50 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 8 seconds (2 minutes 43 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  changelog workflow has finished in 3 seconds (8 minutes 59 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 3 seconds (43 minutes 36 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 36 seconds (6 minutes 22 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 40 minutes 19 seconds (19 minutes 38 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2539  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2539  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2456  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4394  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1871  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1871  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2456  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4394  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 8 minutes 20 seconds (9 minutes 9 seconds less than main branch avg.) and finished at 21st Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@atoulme atoulme changed the title do not close the body of the request explicitly as net/http does that for us [exporter/splunkhecexporter] do not close the body of the request explicitly as net/http does that for us Dec 21, 2022
if err != nil {
t.Fatal(err)
bodyBytes := body
// the last batch might not be zipped.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this created flakiness. Sometimes the last request sent by the batch was not gzipped. We account for it.

}

events := strings.Split(string(bodyBytes), "}{")
firstPayload := events[0]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also sometimes the last batch had just one event. We fix it here by doing a better job separating HEC events.

@dmitryax
Copy link
Member

Please check linter failures

@atoulme atoulme changed the title [exporter/splunkhecexporter] do not close the body of the request explicitly as net/http does that for us [exporter/splunkhecexporter] fix flaky test expecting all requests to be gzipped. Dec 21, 2022
@atoulme atoulme changed the title [exporter/splunkhecexporter] fix flaky test expecting all requests to be gzipped. [chore][exporter/splunkhecexporter] fix flaky test expecting all requests to be gzipped. Dec 21, 2022
@atoulme atoulme changed the title [chore][exporter/splunkhecexporter] fix flaky test expecting all requests to be gzipped. [chore] fix flaky test expecting all requests to be gzipped. Dec 21, 2022
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 21, 2022
@dmitryax dmitryax changed the title [chore] fix flaky test expecting all requests to be gzipped. [chore] [exporter/splunkhec] fix flaky test expecting all requests to be gzipped. Dec 21, 2022
@dmitryax dmitryax merged commit 4eaa9f8 into open-telemetry:main Dec 21, 2022
@atoulme atoulme deleted the fix_close_twice branch December 21, 2022 02:08
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/splunkhec Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants