[exporter/datadog] Add new metrics helper functions based on native APIs #16858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to wait for #16614 to be merged then rebase this PR. |
Foresight Summary
View More Details build-and-test workflow has finished in 18 minutes 6 seconds (42 minutes 24 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| integration-tests | N/A | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
songy23
force-pushed
the
ddog-metrics-helpers-2
branch
from
bc3c003 to
70fe7b1
Compare
songy23
changed the title
|
Please add label Skip Changelog. |
gbbr
approved these changes
Dec 14, 2022
mx-psi
approved these changes
Dec 16, 2022
|
Thanks for the review! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add internal metrics helper functions that consume or transform metrics into native Datadog API format (github.com/DataDog/datadog-api-client-go) rather than Zorkian format.
Most changes are a copy-and-paste of current functions with modifications to github.com/DataDog/datadog-api-client-go data types. This PR only changes internal functions. No public functions are changed yet.
Link to tracking Issue:
#16776
Testing:
Documentation: