Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/signalfxexporter] Add all HTTP client settings to the configuration #16837

Merged
merged 11 commits into from
Jan 2, 2023
Merged

[exporter/signalfxexporter] Add all HTTP client settings to the configuration #16837

merged 11 commits into from
Jan 2, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 10, 2022

Description:
Expose all HTTP client settings to the exporter configuration so they may be set in addition to the existing flags.

Link to tracking Issue:
#16807

Testing:
Unit tests all pass.

Documentation:
N/A - not sure we need to shore up those config settings explicitly as I haven't seen that done elsewhere - please advise.

@atoulme atoulme requested a review from a team December 10, 2022 04:23
@atoulme atoulme requested a review from dmitryax as a code owner December 10, 2022 04:23
@github-actions github-actions bot requested a review from pmcollins December 10, 2022 04:24
@runforesight
Copy link

runforesight bot commented Dec 10, 2022 •
edited
Loading

Foresight Summary

    
Major Impacts

TestRabbitmqIntegration ❌ failed 1 times in 10 runs (10% fail rate).
TestRabbitmqIntegration/Running_rabbitmq_3.9 ❌ failed 1 times in 10 runs (10% fail rate).
build-and-test-windows duration(5 seconds) has decreased 44 minutes 50 seconds compared to main branch avg(44 minutes 55 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (44 minutes 50 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute (3 minutes 1 second less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 30 seconds (2 minutes 9 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 39 seconds (6 minutes 24 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 17 seconds (6 minutes 45 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 8 minutes 6 seconds (9 minutes 16 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 34 minutes 42 seconds (24 minutes 25 seconds less than main branch avg.) and finished at 26th Dec, 2022.

Job Failed Steps Tests
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@atoulme atoulme force-pushed the expose_httpclientsettings branch from 2f956ee to a3471d2 Compare December 10, 2022 04:28
MovieStoreGuy
MovieStoreGuy reviewed Dec 10, 2022
View reviewed changes
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments but I do appreciate making the change so quickly

exporter/signalfxexporter/exporter.go Show resolved Hide resolved
exporter/signalfxexporter/exporter.go Show resolved Hide resolved
@atoulme atoulme force-pushed the expose_httpclientsettings branch 2 times, most recently from 02f9b4f to 5e4cc13 Compare December 10, 2022 06:29
@atoulme atoulme requested a review from a team December 10, 2022 06:29
@atoulme atoulme mentioned this pull request Dec 10, 2022
Closed
@MovieStoreGuy
Copy link
Contributor

I am fine with these changes, however, @dmitryax and @pmcollins should verify these.

dmitryax
dmitryax reviewed Dec 16, 2022
View reviewed changes
exporter/signalfxexporter/exporter.go Outdated Show resolved Hide resolved
exporter/signalfxexporter/exporter.go Outdated Show resolved Hide resolved
@atoulme atoulme mentioned this pull request Dec 16, 2022
Merged
@atoulme atoulme force-pushed the expose_httpclientsettings branch from e50fda8 to 5ef3ff9 Compare December 23, 2022 08:54
dmitryax
dmitryax reviewed Dec 23, 2022
View reviewed changes
exporter/signalfxexporter/config.go Outdated Show resolved Hide resolved
exporter/signalfxexporter/exporter.go Outdated Show resolved Hide resolved
exporter/signalfxexporter/exporter.go Outdated Show resolved Hide resolved
exporter/signalfxexporter/README.md Outdated Show resolved Hide resolved
@atoulme atoulme force-pushed the expose_httpclientsettings branch from 5ed0867 to cef13bf Compare December 26, 2022 09:09
@MovieStoreGuy
Copy link
Contributor

Ready to merge once @dmitryax or @pmcollins approves.

dmitryax
dmitryax approved these changes Jan 2, 2023
View reviewed changes
exporter/signalfxexporter/exporter.go
se.config.HTTPClientSettings.TLSSetting = se.config.IngestTLSSettings

if se.config.HTTPClientSettings.MaxIdleConns == nil {
se.config.HTTPClientSettings.MaxIdleConns = &se.config.MaxConnections
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a deprecation warning log about it. Otherwise, the user will not notice the deprecation. Can be done in a follow-up PR

@dmitryax dmitryax merged commit 0e4954c into open-telemetry:main Jan 2, 2023
@atoulme atoulme mentioned this pull request Jan 23, 2023
Closed
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
This was referenced Oct 11, 2023
Closed
Merged
dmitryax pushed a commit that referenced this pull request Oct 16, 2023
@atoulme
[exporter/signalfx] [exporter/splunkhec] Remove max_connections confi…
b37a55e 
…g parameter (#27611)

**Description:**
The max_connections config setting were deprecated with
#16837
and
#16838.
It has been 10 months since these changes have been made and it is time
to remove this configuration setting altogether.

**Link to tracking Issue:**
#27610
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
@atoulme @JaredTan95
[exporter/signalfx] [exporter/splunkhec] Remove max_connections confi…
10bba48 
…g parameter (open-telemetry#27611)

**Description:**
The max_connections config setting were deprecated with
open-telemetry#16837
and
open-telemetry#16838.
It has been 10 months since these changes have been made and it is time
to remove this configuration setting altogether.

**Link to tracking Issue:**
open-telemetry#27610
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@atoulme @jmsnll
[exporter/signalfx] [exporter/splunkhec] Remove max_connections confi…
e36845c 
…g parameter (open-telemetry#27611)

**Description:**
The max_connections config setting were deprecated with
open-telemetry#16837
and
open-telemetry#16838.
It has been 10 months since these changes have been made and it is time
to remove this configuration setting altogether.

**Link to tracking Issue:**
open-telemetry#27610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
exporter/signalfx testbed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @MovieStoreGuy @dmitryax @fatsheep9146