Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add in reference URLs for feature gates in use. #16517

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[chore] Add in reference URLs for feature gates in use. #16517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
675bdb8
Addin URL references for feature gates
MovieStoreGuy Nov 29, 2022
cf6d700
Updating to reference issue
MovieStoreGuy Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporter/datadogexporter/internal/metadata/host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ func init() {
HostnamePreviewFeatureGate,
featuregate.StageBeta,
featuregate.WithRegisterDescription("Use the 'preview' hostname resolution rules, which are consistent with Datadog cloud integration hostname resolution rules, and set 'host_metadata::hostname_source' to 'config_or_system' by default."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/10424"),
)
}

Expand Down
1 change: 1 addition & 0 deletions exporter/googlecloudexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func init() {
pdataExporterFeatureGate,
featuregate.StageBeta,
featuregate.WithRegisterDescription("When enabled, the googlecloud exporter translates pdata directly to google cloud monitoring's types, rather than first translating to opencensus."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7132"),
)
}

Expand Down
1 change: 1 addition & 0 deletions pkg/translator/prometheus/normalize_label.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ func init() {
dropSanitizationGate,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("Controls whether to change labels starting with '_' to 'key_'."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/8950"),
)
}

Expand Down
1 change: 1 addition & 0 deletions pkg/translator/prometheus/normalize_name.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ func init() {
normalizeNameGateID,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("Controls whether metrics names are automatically normalized to follow Prometheus naming convention"),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/8950"),
)
}

Expand Down
8 changes: 7 additions & 1 deletion processor/cumulativetodeltaprocessor/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ import (
const enableHistogramSupportGateID = "processor.cumulativetodeltaprocessor.EnableHistogramSupport"

func init() {
featuregate.GetRegistry().MustRegisterID(enableHistogramSupportGateID, featuregate.StageBeta, featuregate.WithRegisterDescription("Enables histogram conversion support"))
featuregate.GetRegistry().MustRegisterID(
enableHistogramSupportGateID,
featuregate.StageBeta,
featuregate.WithRegisterDescription("Enables histogram conversion support"),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/15288"),
bogdandrutu marked this conversation as resolved.
Show resolved Hide resolved
featuregate.WithRegisterRemovalVersion("v0.66.0"),
)
}

type cumulativeToDeltaProcessor struct {
Expand Down
2 changes: 2 additions & 0 deletions receiver/apachereceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,13 @@ func init() {
EmitServerNameAsResourceAttribute,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("When enabled, the name of the server will be sent as an apache.server.name resource attribute instead of a metric-level server_name attribute."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/14791"),
)
featuregate.GetRegistry().MustRegisterID(
EmitPortAsResourceAttribute,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("When enabled, the port of the server will be sent as an apache.server.port resource attribute."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/14791"),
)
}

Expand Down
2 changes: 2 additions & 0 deletions receiver/elasticsearchreceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,13 @@ func init() {
emitClusterHealthDetailedShardMetricsID,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("When enabled, the elasticsearch.cluster.shards metric will be emitted with two more datapoints."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/14635"),
)
featuregate.GetRegistry().MustRegisterID(
emitAllIndexOperationMetricsID,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("When enabled, the elasticsearch.index.operation.* metrics will be emitted with all possible datapoints."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/14635"),
)
}

Expand Down
8 changes: 6 additions & 2 deletions receiver/postgresqlreceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,15 @@ func init() {
featuregate.GetRegistry().MustRegisterID(
emitMetricsWithoutResourceAttributesFeatureGateID,
featuregate.StageAlpha,
featuregate.WithRegisterDescription(emitMetricsWithoutResourceAttributesDescription))
featuregate.WithRegisterDescription(emitMetricsWithoutResourceAttributesDescription),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/12960"),
)
featuregate.GetRegistry().MustRegisterID(
emitMetricsWithResourceAttributesFeatureGateID,
featuregate.StageBeta,
featuregate.WithRegisterDescription(emitMetricsWithResourceAttributesDescription))
featuregate.WithRegisterDescription(emitMetricsWithResourceAttributesDescription),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/12960"),
)
}

type postgreSQLScraper struct {
Expand Down