[exporter/instana] Remove redundant Sort call making exporter mutating #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sort call is redundant because the range function is applied on a map so there is no reason to preserve order. The call unnecessarily mutates the original data which can lead to subtle bugs
dmitryax
force-pushed
the
remove-instana-sort
branch
from
5864cb4 to
32f9194
Compare
bogdandrutu
approved these changes
Nov 28, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
open-telemetry#16505) The Sort call is redundant because the range function is applied on a map so there is no reason to preserve order. The call unnecessarily mutates the original data which can lead to subtle bugs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sort call is redundant because the range function is applied on a map so there is no reason to preserve order. The call unnecessarily mutates the original data which can lead to subtle bugs similar to #16499 given that the exporter marked as not mutating