[exporter/clickhouse] export metrics to clickhouse #16477

Frapschen · 2022-11-25T07:01:34Z

Description: export metrics to clickhouse

This is a init pr for clickhouse metrics exporter. please get me some suggestions, I can work on.

JaredTan95 · 2022-11-25T09:33:18Z

@Frapschen you need to fix all faileds CI jobs. :-P

follwoing scrpits may be helpful:

make addlicense
make goporto

hanjm

Awsome work. could you add some design and example to README.md?

exporter/clickhouseexporter/internal/metrics_model.go

runforesight · 2022-12-04T06:27:44Z

Foresight Summary

Major Impacts

build-and-test-windows duration(4 seconds) has decreased 39 minutes 8 seconds compared to main branch avg(39 minutes 12 seconds).

View More Details

✅ tracegen workflow has finished in 8 minutes 21 seconds (⚠️ 6 minutes more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 9 minutes 33 seconds (⚠️ 7 minutes 2 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ check-links workflow has finished in 17 minutes 1 second (⚠️ 15 minutes 16 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 18 minutes 45 seconds (⚠️ 11 minutes 18 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ build-and-test workflow has finished in 1 hour 17 minutes 36 seconds (⚠️ 29 minutes 37 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.19, processor)	- 🔗	✅ 1488 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 666 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2565 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2565 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2500 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2500 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4482 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4482 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1894 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 55 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1894 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
unittest-matrix (1.18, processor)	- 🔗	N/A	See Details
unittest-matrix (1.18, internal)	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
correctness-metrics	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 50 minutes 53 seconds (⚠️ 36 minutes 53 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

⭕ changelog workflow has finished in 3 seconds (2 minutes 1 second less than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

⭕ build-and-test-windows workflow has finished in 4 seconds (39 minutes 8 seconds less than `main` branch avg.) and finished at 19th Jan, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

Frapschen · 2022-12-07T01:21:39Z

anyone know how to fix this workflow error?

Error: factory.go:110:6: SA1019: component.ExporterConfig is deprecated: [v0.67.0] use Config. (staticcheck)
	cfg component.ExporterConfig,

exporter/clickhouseexporter/factory.go

JaredTan95 · 2022-12-08T08:57:45Z

pls resolve conflicts.

exporter/clickhouseexporter/README.md

Frapschen · 2022-12-11T10:25:38Z

All of the work is finished, and ready to merge. @JaredTan95 @hanjm @dmitryax

JaredTan95

LGTM

exporter/clickhouseexporter/exporter_metrics.go

exporter/clickhouseexporter/internal/histogram_metrics.go

exporter/clickhouseexporter/factory.go

atoulme · 2022-12-17T05:28:42Z

exporter/clickhouseexporter/exporter_metrics.go

+	if err := cfg.Validate(); err != nil {
+		return nil, err
+	}
+	if err := createDatabase(cfg); err != nil {


Would it be possible to move this code to a start method, that runs as part of the exporter lifecycle?

The function newMetricsExporter() is follow the style of newTracesExporter(), I think we can use another PR to deal with them.

Can I ask you to create an issue to follow that up with @Frapschen ?

ok,here #17558

exporter/clickhouseexporter/internal/metrics_model.go

atoulme · 2022-12-17T05:30:10Z

exporter/clickhouseexporter/internal/metrics_model.go

+func attributesToMap(attributes pcommon.Map) map[string]string {
+	m := make(map[string]string, attributes.Len())
+	attributes.Range(func(k string, v pcommon.Value) bool {
+		m[k] = v.Str()


Not all values are strings.

In most scenarios, attribute value is string, if it contain other types, the Str() will return a empy strings, I think it's ok for current usecase.

please put a comment to that effect and add tests for this function

This should be using AsString() instead of Str() in the event that non string values are passed in don't cause an empty string to be returned as described by the docs.

exporter/clickhouseexporter/internal/metrics_model.go

MovieStoreGuy

I have a decent amount of comments that I would consider need addressing.

I would comfortable to approve this PR once an the *placeholders are used as needed and not copied into an array of of a constant string.

If you have the time as well, I would appreciate seeing some benchmarks for some of these operations to help quantify the expected performance.

MovieStoreGuy · 2023-01-12T11:49:52Z

.github/CODEOWNERS

@@ -39,7 +39,7 @@ exporter/awsxrayexporter/                                @open-telemetry/collect
 exporter/azuremonitorexporter/                           @open-telemetry/collector-contrib-approvers @pcwiese
 exporter/azuredataexplorerexporter/                      @open-telemetry/collector-contrib-approvers @asaharan @ag-ramachandran
 exporter/carbonexporter/                                 @open-telemetry/collector-contrib-approvers @pjanotti
-exporter/clickhouseexporter/                             @open-telemetry/collector-contrib-approvers @hanjm @dmitryax
+exporter/clickhouseexporter/                             @open-telemetry/collector-contrib-approvers @hanjm @dmitryax @Frapschen


Lets check with @hanjm and @dmitryax if they are okay with an additional code owner.

Thanks, I think it's ok.

MovieStoreGuy · 2023-01-12T11:50:56Z

exporter/clickhouseexporter/README.md

+```
+
+The OTLP Metrics [define two type value for one datapoint](https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L358),
+clickhouse only use one value of float64 to store them.


What does that mean for users sending data with Int type?
Are the dropped? Automatically converted? Are they required to convert them?

convert to float64 Automatically, this come from #16477 (comment)

Lets make it clear to the user that this is automatically done for you and doesn't require any additional work :)

MovieStoreGuy · 2023-01-12T11:53:42Z

exporter/clickhouseexporter/README.md

+Before you make a metrics query, you need to know the type of metric you wish to use. If your metrics come from
+Prometheus(or someone else uses OpenMetrics protocol), you also need to know the
+[compatibility](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#prometheus-and-openmetrics-compatibility)
+between Prometheus(OpenMetrics) and OTLP Metrics.


This feels like it could leave for a bad UX for user's who want to get started with clickhouse, is there any issues in future that look to improve this?

Yes, it's not friendly for users, considering this is designed for storing data in an organized way which means the user query experience is not the primary. I'm not expecting End Users to direct make a query, I think there needs a query layer to hide those details and give a universal way to query. This needs more discussion and it's out of the exporter's scope.

If it was possible to create an issue that can users can track or follow along, either with Clickhouse or in this project. Just so it isn't forgotten or ignored that it can be improved.

MovieStoreGuy · 2023-01-12T11:55:02Z

exporter/clickhouseexporter/exporter_metrics.go

+	if err := cfg.Validate(); err != nil {
+		return nil, err
+	}
+	if err := createDatabase(cfg); err != nil {


Can I ask you to create an issue to follow that up with @Frapschen ?

exporter/clickhouseexporter/exporter_metrics.go

MovieStoreGuy · 2023-01-12T12:47:07Z

exporter/clickhouseexporter/internal/metrics_model.go

+func attributesToMap(attributes pcommon.Map) map[string]string {
+	m := make(map[string]string, attributes.Len())
+	attributes.Range(func(k string, v pcommon.Value) bool {
+		m[k] = v.Str()


This should be using AsString() instead of Str() in the event that non string values are passed in don't cause an empty string to be returned as described by the docs.

exporter/clickhouseexporter/internal/metrics_model.go

MovieStoreGuy

It looks like my comments have been addressed so I will remove my requests for changes however, I do believe there is some optimisations to be had with handling strings.

MovieStoreGuy · 2023-01-16T08:20:21Z

exporter/clickhouseexporter/exporter_metrics_test.go

+		mutex := sync.Mutex{}
+		var items int


In future, if you wanted to not use a mutex, you could use atomic.Int64 instead :)

MovieStoreGuy · 2023-01-16T08:22:13Z

exporter/clickhouseexporter/exporter_metrics_test.go

+	return metrics
+}
+
+func mustPushMetricsData(t *testing.T, exporter *metricsExporter, md pmetric.Metrics) {


Use tb testing.TB instead of *testing.T so that they can be used between benchmarks, tests, and fuzzing :)

MovieStoreGuy · 2023-01-16T08:22:27Z

exporter/clickhouseexporter/exporter_metrics_test.go

+	require.NoError(t, err)
+}
+
+func newTestMetricsExporter(t *testing.T, dsn string, fns ...func(*Config)) *metricsExporter {


Same as above

MovieStoreGuy · 2023-01-16T08:30:42Z

exporter/clickhouseexporter/internal/metrics_model.go

+	createSummaryTableSQL:      {},
+}
+
+var logger *zap.Logger


I would prefer not using a package level variable since it can be rather hazardous due to concurrent usage.

MovieStoreGuy · 2023-01-16T08:32:43Z

exporter/clickhouseexporter/internal/metrics_model.go

+// SetLogger set a logger instance
+func SetLogger(l *zap.Logger) {
+	logger = l
+}


This method isn't safe for concurrent usage and not a pattern I'd like to encourage in the project.

If a method / function needs a logger, please add it as part of the params or type instead.

MovieStoreGuy · 2023-01-16T09:28:23Z

exporter/clickhouseexporter/internal/metrics_model.go

+		return fmt.Errorf("db.Begin: %w", err)
+	}
+	defer func() {
+		_ = tx.Rollback()


Does this mean that on each Transaction that a rollback is performed?

MovieStoreGuy · 2023-01-16T09:43:29Z

exporter/clickhouseexporter/exporter_metrics_test.go

+	rm.Resource().Attributes().PutStr("service.name", "demo 1")
+	rm.Resource().Attributes().PutStr("Resource Attributes 1", "value1")
+	rm.Resource().SetDroppedAttributesCount(10)
+	rm.SetSchemaUrl("Resource SchemaUrl 1")


Please use a properly formatted URL here, http://example.com/schema/1.0.0 is fine to use.

MovieStoreGuy · 2023-01-16T09:46:38Z

exporter/clickhouseexporter/factory.go

-		TracesTableName: "otel_traces",
-		TTLDays:         7,
+		TimeoutSettings:  exporterhelper.NewDefaultTimeoutSettings(),
+		QueueSettings:    QueueSettings{QueueSize: exporterhelper.NewDefaultQueueSettings().QueueSize},


Any reason not to do:

QueueSettings: exporterhelper.NewDefaultQueueSettings()

MovieStoreGuy · 2023-01-16T09:48:03Z

exporter/clickhouseexporter/internal/exponential_histogram_metrics.go

+CREATE TABLE IF NOT EXISTS %s_exponential_histogram (
+    ResourceAttributes Map(LowCardinality(String), String) CODEC(ZSTD(1)),
+    ResourceSchemaUrl String CODEC(ZSTD(1)),
+    ScopeName String CODEC(ZSTD(1)),
+    ScopeVersion String CODEC(ZSTD(1)),
+    ScopeAttributes Map(LowCardinality(String), String) CODEC(ZSTD(1)),
+    ScopeDroppedAttrCount UInt32 CODEC(ZSTD(1)),
+    ScopeSchemaUrl String CODEC(ZSTD(1)),
+    MetricName String CODEC(ZSTD(1)),
+    MetricDescription String CODEC(ZSTD(1)),
+    MetricUnit String CODEC(ZSTD(1)),
+    Attributes Map(LowCardinality(String), String) CODEC(ZSTD(1)),
+	StartTimeUnix DateTime64(9) CODEC(Delta, ZSTD(1)),
+	TimeUnix DateTime64(9) CODEC(Delta, ZSTD(1)),
+    Count Int64 CODEC(Delta, ZSTD(1)),
+    Sum Float64 CODEC(ZSTD(1)),
+    Scale Int32 CODEC(ZSTD(1)),
+    ZeroCount UInt64 CODEC(ZSTD(1)),
+	PositiveOffset Int32 CODEC(ZSTD(1)),
+	PositiveBucketCounts Array(UInt64) CODEC(ZSTD(1)),
+	NegativeOffset Int32 CODEC(ZSTD(1)),
+	NegativeBucketCounts Array(UInt64) CODEC(ZSTD(1)),
+	Exemplars Nested (
+		FilteredAttributes Map(LowCardinality(String), String),
+		TimeUnix DateTime64(9),
+		Value Float64,
+		SpanId String,
+		TraceId String
+    ) CODEC(ZSTD(1)),
+    Flags UInt32  CODEC(ZSTD(1)),
+    Min Float64 CODEC(ZSTD(1)),
+    Max Float64 CODEC(ZSTD(1))
+) ENGINE MergeTree()
+%s
+PARTITION BY toDate(TimeUnix)
+ORDER BY (MetricName, Attributes, toUnixTimestamp64Nano(TimeUnix))
+SETTINGS index_granularity=8192, ttl_only_drop_parts = 1;
+`


Is there a way this can be tested?

MovieStoreGuy · 2023-01-16T10:33:58Z

exporter/clickhouseexporter/internal/exponential_histogram_metrics.go

+
+	start := time.Now()
+	err := doWithTx(ctx, db, func(tx *sql.Tx) error {
+		_, err := tx.ExecContext(ctx, fmt.Sprintf("%s %s", e.insertSQL, strings.TrimSuffix(b.String(), ",")), valueArgs...)


Is there a concern with large amounts of inserts being done within the same transaction?

no. it's not a transaction, clickhouse driver will do batch insert.

Leaving final approval for code owner

exporter/clickhouseexporter/README.md

Frapschen requested a review from a team November 25, 2022 07:01

Frapschen requested a review from dmitryax as a code owner November 25, 2022 07:01

github-actions bot assigned TylerHelmuth Nov 25, 2022

github-actions bot added the exporter/clickhouse label Nov 25, 2022

github-actions bot requested a review from hanjm November 25, 2022 07:01

hanjm reviewed Nov 26, 2022

View reviewed changes

exporter/clickhouseexporter/internal/metrics_model.go Outdated Show resolved Hide resolved

exporter/clickhouseexporter/internal/metrics_model.go Outdated Show resolved Hide resolved

github-actions bot requested a review from hanjm November 27, 2022 14:29

hanjm approved these changes Nov 28, 2022

View reviewed changes

github-actions bot requested a review from hanjm November 29, 2022 09:21

JaredTan95 reviewed Dec 8, 2022

View reviewed changes

exporter/clickhouseexporter/factory.go Outdated Show resolved Hide resolved

Frapschen force-pushed the clickhouse_metrics_exporter branch from 0dd0b55 to 010e3b7 Compare December 8, 2022 10:34

JaredTan95 suggested changes Dec 9, 2022

View reviewed changes

exporter/clickhouseexporter/README.md Outdated Show resolved Hide resolved

Frapschen force-pushed the clickhouse_metrics_exporter branch 2 times, most recently from 3816a56 to b565a2f Compare December 11, 2022 09:43

JaredTan95 approved these changes Dec 12, 2022

View reviewed changes

hanjm approved these changes Dec 12, 2022

View reviewed changes

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/exporter_metrics.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/exporter_metrics.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/exporter_metrics.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/internal/histogram_metrics.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/factory.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/internal/metrics_model.go Outdated Show resolved Hide resolved

atoulme reviewed Dec 17, 2022

View reviewed changes

exporter/clickhouseexporter/internal/metrics_model.go Outdated Show resolved Hide resolved

Frapschen force-pushed the clickhouse_metrics_exporter branch from c1267c5 to 2273bbf Compare January 10, 2023 10:41

Frapschen added 5 commits January 10, 2023 18:49

fix

e39828f

apply

5c710ae

apply

d7349c8

fix data race

19f8390

fix data race in ut

8a5348e

atoulme approved these changes Jan 12, 2023

View reviewed changes

MovieStoreGuy previously requested changes Jan 12, 2023

View reviewed changes

hanjm reviewed Jan 13, 2023

View reviewed changes

exporter/clickhouseexporter/internal/metrics_model.go Outdated Show resolved Hide resolved

Frapschen added 8 commits January 14, 2023 00:47

apply

7fd6469

apply

021d2ed

apply

27628db

fix ut

e279431

fix lint

60a58fe

update

6450b26

update

dbd248e

fix lint

b41365f

Frapschen requested a review from MovieStoreGuy January 16, 2023 05:48

fix lint

04f73f4

MovieStoreGuy reviewed Jan 16, 2023

View reviewed changes

MovieStoreGuy self-requested a review January 16, 2023 10:37

dmitryax approved these changes Jan 19, 2023

View reviewed changes

exporter/clickhouseexporter/README.md Outdated Show resolved Hide resolved

Update exporter/clickhouseexporter/README.md

e52f4d2

dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 19, 2023

dmitryax merged commit 8821292 into open-telemetry:main Jan 20, 2023

Frapschen mentioned this pull request Jan 20, 2023

[exporter/clickhouse] improve the metrics query UX for users #17875

Closed

dmitryax mentioned this pull request Jan 26, 2023

[exporter/clickhouse] Sent metrics to clickhouse #16478

Closed

plantfansam mentioned this pull request Jul 21, 2023

disregard #24427

Closed

Frapschen deleted the clickhouse_metrics_exporter branch August 3, 2024 10:02

[exporter/clickhouse] export metrics to clickhouse #16477

[exporter/clickhouse] export metrics to clickhouse #16477

Conversation

Frapschen commented Nov 25, 2022 • edited Loading

JaredTan95 commented Nov 25, 2022 • edited Loading

hanjm left a comment

Choose a reason for hiding this comment

runforesight bot commented Dec 4, 2022 • edited Loading

Foresight Summary

build-and-test-windows duration(4 seconds) has decreased 39 minutes 8 seconds compared to main branch avg(39 minutes 12 seconds).

✅ tracegen workflow has finished in 8 minutes 21 seconds (⚠️ 6 minutes more than main branch avg.) and finished at 19th Jan, 2023.

✅ telemetrygen workflow has finished in 9 minutes 33 seconds (⚠️ 7 minutes 2 seconds more than main branch avg.) and finished at 19th Jan, 2023.

✅ check-links workflow has finished in 17 minutes 1 second (⚠️ 15 minutes 16 seconds more than main branch avg.) and finished at 19th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 18 minutes 45 seconds (⚠️ 11 minutes 18 seconds more than main branch avg.) and finished at 19th Jan, 2023.

✅ build-and-test workflow has finished in 1 hour 17 minutes 36 seconds (⚠️ 29 minutes 37 seconds more than main branch avg.) and finished at 19th Jan, 2023.

✅ load-tests workflow has finished in 50 minutes 53 seconds (⚠️ 36 minutes 53 seconds more than main branch avg.) and finished at 19th Jan, 2023.

⭕ changelog workflow has finished in 3 seconds (2 minutes 1 second less than main branch avg.) and finished at 19th Jan, 2023.

⭕ build-and-test-windows workflow has finished in 4 seconds (39 minutes 8 seconds less than main branch avg.) and finished at 19th Jan, 2023.

Frapschen commented Dec 7, 2022

JaredTan95 commented Dec 8, 2022

Frapschen commented Dec 11, 2022 • edited Loading

JaredTan95 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MovieStoreGuy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MovieStoreGuy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Frapschen commented Nov 25, 2022 •

edited

Loading

JaredTan95 commented Nov 25, 2022 •

edited

Loading

runforesight bot commented Dec 4, 2022 •

edited

Loading

`build-and-test-windows` duration(4 seconds) has decreased 39 minutes 8 seconds compared to main branch avg(39 minutes 12 seconds).

✅ tracegen workflow has finished in 8 minutes 21 seconds (⚠️ 6 minutes more than `main` branch avg.) and finished at 19th Jan, 2023.

✅ telemetrygen workflow has finished in 9 minutes 33 seconds (⚠️ 7 minutes 2 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

✅ check-links workflow has finished in 17 minutes 1 second (⚠️ 15 minutes 16 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 18 minutes 45 seconds (⚠️ 11 minutes 18 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

✅ build-and-test workflow has finished in 1 hour 17 minutes 36 seconds (⚠️ 29 minutes 37 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

✅ load-tests workflow has finished in 50 minutes 53 seconds (⚠️ 36 minutes 53 seconds more than `main` branch avg.) and finished at 19th Jan, 2023.

⭕ changelog workflow has finished in 3 seconds (2 minutes 1 second less than `main` branch avg.) and finished at 19th Jan, 2023.

⭕ build-and-test-windows workflow has finished in 4 seconds (39 minutes 8 seconds less than `main` branch avg.) and finished at 19th Jan, 2023.

Frapschen commented Dec 11, 2022 •

edited

Loading