Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split internal/coreinternal/processor into a separate internal/filter module #16410

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Split internal/coreinternal/processor into a separate internal/filter module #16410

merged 1 commit into from
Nov 22, 2022

Conversation

bogdandrutu
Copy link
Member

Allows to avoid dependency on OTTL in all packages (after we change filter to use ottl).

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team November 21, 2022 21:19
TylerHelmuth
TylerHelmuth reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between internal and internal/coreinternal? I like the idea of moving filter out of a processor-specific package, but should it still be in coreinternal?

@bogdandrutu
Copy link
Member Author

coreinternal was a historical package that was moved from "core" repo. No other meaning of "core", so I don't think we need it in "coreinternal"

@bogdandrutu
Copy link
Member Author

Also, all of these are internal packages, so we can play with the structure as much as we want :)

@bogdandrutu bogdandrutu force-pushed the splitfilter branch 3 times, most recently from 39e3f4e to 0b898a0 Compare November 21, 2022 23:15
@bogdandrutu
Split internal/coreinternal/processor into a separate internal/filter…
62af0f1 
… module

Allows to avoid dependency on OTTL in all packages (after we change filter to use ottl).

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu merged commit 7b88749 into open-telemetry:main Nov 22, 2022
@bogdandrutu bogdandrutu deleted the splitfilter branch November 22, 2022 01:51
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@bogdandrutu @shalper2
Split internal/coreinternal/processor into a separate internal/filter…
5f59704 
… module (open-telemetry#16410)

Allows to avoid dependency on OTTL in all packages (after we change filter to use ottl).

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@punya punya Awaiting requested review from punya

Assignees

@evan-bradley evan-bradley

Labels
cmd/configschema configschema command exporter/alibabacloudlogservice Alibaba components exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/clickhouse exporter/datadog Datadog components exporter/elasticsearch exporter/googlecloud exporter/humio exporter/instana exporter/loki Loki Exporter exporter/prometheusremotewrite exporter/sentry exporter/signalfx exporter/skywalking exporter/tanzuobservability exporter/tencentcloudlogservice internal/core pkg/resourcetotelemetry processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/filter Filter processor processor/logstransform Logs Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/resource Resource processor processor/span
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @TylerHelmuth @evan-bradley