-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/elasticsearch]: add missing datapoints for operation count and operation time metrics #16170
[receiver/elasticsearch]: add missing datapoints for operation count and operation time metrics #16170
Conversation
58bc61b
to
c2968f0
Compare
I initially thought this should be a bug fix because it appeared that we had missed a data point or two on an existing metric. However, I do not think adding 30+ data points to a metric is in the spirit of "fixing a mistake". I do think that adding these is fine, but we should declare it an enhancement and use a feature gate. |
c2968f0
to
dbf7f96
Compare
To be honest, all of these datapoints aren't necessary for me (only some arbitrarily chosen ones), but |
dbf7f96
to
72cdb63
Compare
@djaglowski I added feature gates. |
…and operation time metrics (open-telemetry#16170) * feat: add missing operation count datapoints with total aggregation * feat: add missing operation count datapoints with primary shards aggregation * feat: add missing operation time datapoints with total shard aggregation * feat: add missing operation time datapoints with primary shards aggregations
…and operation time metrics (open-telemetry#16170) * feat: add missing operation count datapoints with total aggregation * feat: add missing operation count datapoints with primary shards aggregation * feat: add missing operation time datapoints with total shard aggregation * feat: add missing operation time datapoints with primary shards aggregations
Description:
All missing datapoints for metrics
elasticsearch.index.operation.count
andelasticsearch.index.operation.time
have been added. This PR also replaces the following PRs: #14871 #14921 #14924The rationale for this PR is explained here: #14924 (comment)
Link to tracking Issue: #14635
Testing:
Unit and integration tests
Documentation:
mdatagen