[processor/resourcedetectionprocessor] support openshift

[frzifus]

Description:

This pr adds openshift support to the resourcedetectionprocessor.

Link to tracking Issue:
Closes #15694

Testing:
A few tests have been added.

The detector can be tested manually with the following configuration:

receivers:
  otlp:
    protocols:
      grpc:
      http:

processors:
  resourcedetection/openshift:
    detectors: openshift
    timeout: 2s
    override: false
    openshift:
      address: https://api.openshift.com
      token: <your-serviceaccount-token>

exporters:
  logging:
    logLevel: debug

service:
  pipelines:
    traces:
      processors: [resourcedetection/openshift]
      receivers: [otlp]
      exporters: [logging]

If the collector is rolled out in an OpenShift cluster, there is no need for user configuration. Note that the used serviceaccount must be authorized to read the api endpoints /apis/config.openshift.io/v1/infrastructures/{name}/status and /apis/config.openshift.io/v1/clusterversions/{name}/status.

Example:

{
  "cloud.platform": "aws_openshift",
  "cloud.provider": "aws",
  "cloud.region": "us-east-1",
  "k8s.cluster.name": "observability-test",
  "k8s.cluster.version": "v1.21.11+5cc9227",
  "openshift.cluster.version": "4.8.51"
}

Documentation:
Extended readme

[frzifus]

@pavolloffay @kevinearls would like to hear your thoughts on this.

[frzifus]

@Aneurysm9 @dashpole could you please have a look? (OT: seems there are some flaky tests on the mainline, could you retrigger it?)

[dashpole]

Maybe this is what the comment is saying, but we need to update https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/resource/cloud.yaml to include these new values.

[frzifus]

right, i wasnt sure if it needs to part of the spec before we can continue here. I will work on that 👍

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[runforesight]

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 44 minutes 6 seconds compared to main branch avg(44 minutes 10 seconds).

View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (44 minutes 6 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
windows-unittest-matrix	-     🔗	N/A	See Details
windows-unittest	-     🔗	N/A	See Details

---

✅  tracegen workflow has finished in 57 seconds (1 minute 36 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
build-dev	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

✅  changelog workflow has finished in 1 minute 19 seconds (56 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
changelog	-     🔗	N/A	See Details

---

✅  check-links workflow has finished in 1 minute 43 seconds and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
changed files	-     🔗	N/A	See Details
check-links	-     🔗	N/A	See Details

---

✅  telemetrygen workflow has finished in 1 minute 6 seconds (1 minute 35 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
build-dev	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details

---

✅  build-and-test workflow has finished in 41 minutes 31 seconds (7 minutes 36 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
unittest-matrix (1.19, internal)	-     🔗	✅ 650  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, extension)	-     🔗	✅ 528  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, internal)	-     🔗	✅ 650  ❌ 0  ⏭ 0    🔗	See Details
correctness-metrics	-     🔗	✅ 2  ❌ 0  ⏭ 0    🔗	See Details
correctness-traces	-     🔗	✅ 17  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, processor)	-     🔗	✅ 1488  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, processor)	-     🔗	✅ 1488  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, extension)	-     🔗	✅ 528  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-0)	-     🔗	✅ 2565  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, receiver-0)	-     🔗	✅ 2565  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, exporter)	-     🔗	✅ 2467  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, other)	-     🔗	✅ 4438  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, other)	-     🔗	✅ 4438  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.19, receiver-1)	-     🔗	✅ 1887  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, receiver-1)	-     🔗	✅ 1887  ❌ 0  ⏭ 0    🔗	See Details
unittest-matrix (1.18, exporter)	-     🔗	✅ 2467  ❌ 0  ⏭ 0    🔗	See Details
integration-tests	-     🔗	✅ 55  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details
check-codeowners	-     🔗	N/A	See Details
check-collector-module-version	-     🔗	N/A	See Details
checks	-     🔗	N/A	See Details
lint-matrix (receiver-0)	-     🔗	N/A	See Details
lint-matrix (receiver-1)	-     🔗	N/A	See Details
lint-matrix (processor)	-     🔗	N/A	See Details
lint-matrix (exporter)	-     🔗	N/A	See Details
lint-matrix (extension)	-     🔗	N/A	See Details
lint-matrix (internal)	-     🔗	N/A	See Details
lint-matrix (other)	-     🔗	N/A	See Details
build-examples	-     🔗	N/A	See Details
unittest (1.19)	-     🔗	N/A	See Details
unittest (1.18)	-     🔗	N/A	See Details
lint	-     🔗	N/A	See Details
cross-compile (darwin, amd64)	-     🔗	N/A	See Details
cross-compile (darwin, arm64)	-     🔗	N/A	See Details
cross-compile (linux, amd64)	-     🔗	N/A	See Details
cross-compile (linux, 386)	-     🔗	N/A	See Details
cross-compile (linux, arm)	-     🔗	N/A	See Details
cross-compile (linux, arm64)	-     🔗	N/A	See Details
cross-compile (linux, ppc64le)	-     🔗	N/A	See Details
cross-compile (windows, 386)	-     🔗	N/A	See Details
cross-compile (windows, amd64)	-     🔗	N/A	See Details
build-package (deb)	-     🔗	N/A	See Details
build-package (rpm)	-     🔗	N/A	See Details
windows-msi	-     🔗	N/A	See Details
publish-check	-     🔗	N/A	See Details
publish-dev	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

✅  load-tests workflow has finished in 8 minutes 37 seconds (6 minutes 37 seconds less than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	-     🔗	✅ 3  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestIdleMode)	-     🔗	✅ 1  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile)	-     🔗	✅ 6  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs)	-     🔗	✅ 8  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs)	-     🔗	✅ 10  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS)	-     🔗	✅ 12  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestBallastMemory|TestLog10kDPS)	-     🔗	✅ 19  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details

---

✅  prometheus-compliance-tests workflow has finished in 13 minutes 24 seconds (⚠️ 5 minutes 15 seconds more than main branch avg.) and finished at 12th Jan, 2023.

---

Job	Failed Steps	Tests
prometheus-compliance-tests	-     🔗	✅ 21  ❌ 0  ⏭ 0    🔗	See Details

---

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[frzifus]

@dashpole, could you please take another look? :)

[dashpole]

Code changes lgtm.

Before we merge this, we should identify CODEOWNERS for the openshift detection logic. Are you interested in being a CODEOWNER for the openshift resource detection portion?

[frzifus]

Thanks for the quick review :)

Before we merge this, we should identify CODEOWNERS for the openshift detection logic. Are you interested in being a CODEOWNER for the openshift resource detection portion?

sure, have added me to the codeowners file. Thats right?

[codeboten]

It looks like some of the checks are still failing

[frzifus]

It looks like some of the checks are still failing

Seems that the issue templates were not up to date and a removed variable was not committed. 😮‍💨

[frzifus]

@codeboten is there something else blocking this?

[codeboten]

LGTM, @dashpole not sure what happened to your approval, can you please have one more look.