[receiver/snmp] Snmp add integration tests #15674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamir-michaeli
changed the title
|
pinging @djaglowski @StefanKurek as code owners |
djaglowski
reviewed
Oct 28, 2022
receiver/snmpreceiver/testdata/integration/v3_config_expected_metrics.json
Outdated
Show resolved
Hide resolved
StefanKurek
reviewed
Oct 31, 2022
receiver/snmpreceiver/testdata/integration/integration_test_v2c_config.yaml
Outdated
Show resolved
Hide resolved
receiver/snmpreceiver/testdata/integration/integration_test_v2c_config.yaml
Show resolved
Hide resolved
djaglowski
reviewed
Nov 3, 2022
| 1.3.6.1.4.1.2021.10.1.4.3|4|Load-3 | ||
| 1.3.6.1.4.1.2021.10.1.5.1|2|1 | ||
| 1.3.6.1.4.1.2021.10.1.5.2|2|2 | ||
| 1.3.6.1.4.1.2021.10.1.5.3|2|3 |
There was a problem hiding this comment.
Suggested change
| 1.3.6.1.4.1.2021.10.1.5.3|2|3 | |
| 1.3.6.1.4.1.2021.10.1.5.3|2|3 | |
| pipelines: | ||
| metrics: | ||
| receivers: [snmp] | ||
| exporters: [nop] |
There was a problem hiding this comment.
Suggested change
| exporters: [nop] | |
| exporters: [nop] | |
| pipelines: | ||
| metrics: | ||
| receivers: [snmp] | ||
| exporters: [nop] |
There was a problem hiding this comment.
Suggested change
| exporters: [nop] | |
| exporters: [nop] | |
| ] | ||
| } | ||
| ] | ||
| } |
| ] | ||
| } | ||
| ] | ||
| } |
receiver/snmpreceiver/testdata/integration/integration_test_v2c_config.yaml
Show resolved
Hide resolved
|
@tamir-michaeli, this looks good - just need to fix the file endings and resolve conflicts |
…c, expected metrics and config files
djaglowski
approved these changes
Nov 8, 2022
dineshg13
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
* SNMP Receiver added integration tests Co-authored-by: Stefan Kurek <[email protected]>
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
* SNMP Receiver added integration tests Co-authored-by: Stefan Kurek <[email protected]>
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds integration tests for the SNMP Metric Receiver.
Link to tracking Issue:
#13409
Testing:
Added integration tests for scraper functionality
Documentation:
No new documentation needed