Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/transform] Add new Context-specific configuration options #15381

Merged
merged 32 commits into from
Nov 10, 2022
Merged

[processor/transform] Add new Context-specific configuration options #15381

merged 32 commits into from
Nov 10, 2022

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Oct 21, 2022 •
edited
Loading

Description:
Adds new configuration option to specify a context associated with statements. See linked issue for discussion on final config structure.

Old configuration option and all supporting APIs are deprecated and will be removed in a future version.

Link to tracking Issue:
Resolves #14578

Testing:
Unit tests

Documentation:
Updated README

@TylerHelmuth TylerHelmuth mentioned this pull request Oct 21, 2022
Merged
@TylerHelmuth TylerHelmuth mentioned this pull request Oct 26, 2022
Closed
@TylerHelmuth TylerHelmuth marked this pull request as ready for review November 8, 2022 19:02
@TylerHelmuth TylerHelmuth requested a review from a team November 8, 2022 19:02
djaglowski
djaglowski reviewed Nov 9, 2022
View reviewed changes
processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/README.md Show resolved Hide resolved
fujin
fujin approved these changes Nov 9, 2022
View reviewed changes
Copy link

@fujin fujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random community member drive-by go! +1 Looks great!

From what I can tell of the code, it's well formed, adequately tested, and the design is sound (based on observing discussions leading up to this). We are excited to use this!

djaglowski
djaglowski approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evan-bradley
evan-bradley approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work here, this is a big step forward.

processor/transformprocessor/README.md Outdated Show resolved Hide resolved
processor/transformprocessor/README.md Show resolved Hide resolved
processor/transformprocessor/testdata/config.yaml Outdated Show resolved Hide resolved
kentquirk
kentquirk approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion on wording, but this is awesome work and I really support this.

processor/transformprocessor/README.md Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Nov 10, 2022
@github-actions github-actions bot added the processor/transform Transform processor label Nov 10, 2022
@djaglowski djaglowski merged commit 7b21298 into open-telemetry:main Nov 10, 2022
@TylerHelmuth TylerHelmuth deleted the tp-enhanced-contexts branch November 10, 2022 20:13
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@TylerHelmuth @shalper2
[processor/transform] Add new Context-specific configuration options (o…
80537f0 
…pen-telemetry#15381)
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@djaglowski djaglowski djaglowski approved these changes

@kentquirk kentquirk kentquirk approved these changes

@fujin fujin fujin approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kovrus kovrus Awaiting requested review from kovrus

Assignees

@Aneurysm9 Aneurysm9

Labels
processor/transform Transform processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[processor/transform] Efficiently interact with higher-scope contexts
6 participants
@TylerHelmuth @fujin @kentquirk @djaglowski @evan-bradley @Aneurysm9