Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/snmp] SNMP Receiver adds config helper #15380

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[receiver/snmp] SNMP Receiver adds config helper #15380

merged 1 commit into from
Oct 24, 2022

Conversation

StefanKurek
Copy link
Contributor

@StefanKurek StefanKurek commented Oct 21, 2022

Description:
Adds a help struct for the SNMP config to be used by the SNMP Receiver metric scraper.

Link to tracking Issue:
#13409

Testing:
Unit tests added for new config helper functionality

Documentation:
No new documentation needed

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. One pattern to iterate on again, but otherwise just nits.

receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
@StefanKurek StefanKurek marked this pull request as ready for review October 24, 2022 06:04
@StefanKurek StefanKurek requested review from a team, dmitryax and djaglowski and removed request for dmitryax October 24, 2022 06:04
receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/config_helper.go Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit f3b260f into open-telemetry:main Oct 24, 2022
@StefanKurek StefanKurek deleted the snmp-add-config-helper branch October 24, 2022 13:58
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants