Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/snmp] SNMP Receiver create OTEL metric helper #15357

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[receiver/snmp] SNMP Receiver create OTEL metric helper #15357

merged 1 commit into from
Oct 20, 2022

Conversation

StefanKurek
Copy link
Contributor

Description:
SNMP Receiver added a OTEL Metric Helper struct for use by the metric scraper

Link to tracking Issue:
#13409

Testing:
Unit tests added for new helper functionality

Documentation:
No new documentation needed

@StefanKurek StefanKurek requested a review from a team October 20, 2022 18:22
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just asking for the updated comment

receiver/snmpreceiver/otel_metric_helper.go Show resolved Hide resolved
Also changing snmpData to public SNMPData as there will be CI issues later when mocking.
@djaglowski djaglowski merged commit abe2ff0 into open-telemetry:main Oct 20, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…ry#15357)

SNMP Recever refactor out OTEL metric helper struct for scraper

Also changing snmpData to public SNMPData as there will be CI issues later when mocking.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants