Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/cumulativetodelta] Reduce Memory Consumption #14729

Merged

Conversation

balintzs
Copy link
Contributor

@balintzs balintzs commented Oct 5, 2022

Description:
This change removes the unnecessary storage of metric identities.

Metric identities are only required for building the keys to look up items in the store. They do not need to be stored themselves.

Link to tracking Issue: #13751

Testing:
Memory consumption before and after:
Screenshot 2022-10-05 at 14 41 58

CPU throttling before and after:
Screenshot 2022-10-05 at 14 42 11

@balintzs balintzs requested a review from a team October 5, 2022 13:43
@balintzs balintzs requested a review from TylerHelmuth as a code owner October 5, 2022 13:43
Remove unnecessary storage of metric identity containing all the associated attribute values.

Add changelog
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

@bogdandrutu bogdandrutu merged commit 93bdbf6 into open-telemetry:main Oct 6, 2022
@balintzs balintzs deleted the c2d-reduce-memory-consumption branch October 6, 2022 07:43
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants